Migrate Kyper ChevronRight Icon to MXUI - #357
Open
mwclemy wants to merge 2 commits into
Open
Conversation
mwclemy
requested review from
Jameson13B,
ash-wright123,
codingLogan and
wesrisenmay-mx
as code owners
July 29, 2026 18:22
| endIcon={ | ||
| !institution.is_disabled_by_client && ( | ||
| <ChevronRight color={tokens.TextColor.Default} height={16} width={16} /> | ||
| <Icon name="chevron_right" size={16} sx={{ color: tokens.TextColor.Default }} /> |
Collaborator
There was a problem hiding this comment.
Let's use the material theme colors
| > | ||
| {__('Data requested')} | ||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={16} sx={{ marginLeft: '13.02px' }} /> |
Collaborator
There was a problem hiding this comment.
Let's use a stack with spacing
| {_p('connect/disclosure/policy/link', 'MX Privacy Policy')} | ||
|
|
||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={16} sx={{ marginLeft: '13.02px' }} /> |
Collaborator
There was a problem hiding this comment.
Stack with spacing
| > | ||
| <PoweredByMXText /> | ||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={16} sx={{ marginLeft: 4 }} /> |
Collaborator
There was a problem hiding this comment.
Stack with spacing
| {__('Visit website')} | ||
| </Link> | ||
| <ChevronRight color={tokens.Color.Primary300} /> | ||
| <Icon name="chevron_right" size={16} sx={{ color: tokens.Color.Primary300 }} /> |
Collaborator
There was a problem hiding this comment.
Color prop or theme variable
| <div style={styles.actionArea}> | ||
| <Link onClick={onRefreshClick}>{__('Try again')}</Link> | ||
| <ChevronRight color={tokens.Color.Primary300} /> | ||
| <Icon name="chevron_right" size={16} sx={{ color: tokens.Color.Primary300 }} /> |
Collaborator
There was a problem hiding this comment.
Color prop or theme variable
| <Icon | ||
| name="chevron_right" | ||
| size={16} | ||
| sx={{ color: tokens.TextColor.ButtonLinkTertiary }} |
Collaborator
There was a problem hiding this comment.
Color prop or theme variable
| <Icon | ||
| name="chevron_right" | ||
| size={16} | ||
| sx={{ color: tokens.TextColor.ButtonLinkTertiary }} |
Collaborator
There was a problem hiding this comment.
Color prop or theme variable
platypus801
reviewed
Jul 30, 2026
| borderType="inset-left" | ||
| onClick={selectGeneralSupport} | ||
| rightChildren={<ChevronRight />} | ||
| rightChildren={<Icon name="chevron_right" size={16} />} |
There was a problem hiding this comment.
size should be 24px as per designs
platypus801
reviewed
Jul 30, 2026
| > | ||
| {__('Other available data')} | ||
| <ChevronRight style={styles.chevron} /> | ||
| <Icon name="chevron_right" size={16} /> |
platypus801
reviewed
Jul 30, 2026
| fadeOut(ref.current, 'up', 300).then(props.handleAccountTypeSelect(account_type)) | ||
| } | ||
| rightChildren={<ChevronRight />} | ||
| rightChildren={<Icon name="chevron_right" size={16} />} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before(Kyper)
After(MXUI)