Skip to content

Migrate Kyper ChevronRight Icon to MXUI #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwclemy wants to merge 2 commits into
base: cmwimo/CT-2388
Choose a base branch
from
Open

Migrate Kyper ChevronRight Icon to MXUI #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1dca52
migrated ChevronRight kyper component
Jul 29, 2026
21a7405
chore: trigger CI
Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/components/InstitutionTile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import { __ } from 'src/utilities/Intl'
import { useTokens } from '@kyper/tokenprovider'

import { Button, Chip } from '@mui/material'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { InstitutionLogo } from '@mxenabled/mxui'
import { Icon, InstitutionLogo } from '@mxenabled/mxui'

import { formatUrl } from 'src/utilities/FormatUrl'
import {
Expand Down Expand Up @@ -36,7 +35,7 @@ export const InstitutionTile = (props) => {
data-test={`${institution.name.replace(/\s+/g, '-')}-row`}
endIcon={
!institution.is_disabled_by_client && (
<ChevronRight color={tokens.TextColor.Default} height={16} width={16} />
<Icon name="chevron_right" size={16} sx={{ color: tokens.TextColor.Default }} />

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the material theme colors

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also size needs to be 24px

)
}
fullWidth={true}
Expand Down
5 changes: 2 additions & 3 deletions src/components/support/SupportMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import PropTypes from 'prop-types'

import { useTokens } from '@kyper/tokenprovider'
import { UtilityRow } from '@kyper/utilityrow'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Text } from '@mxenabled/mxui'
import { Icon, Text } from '@mxenabled/mxui'

import { __ } from 'src/utilities/Intl'

Expand Down Expand Up @@ -32,7 +31,7 @@ export const SupportMenu = React.forwardRef((props, menuRef) => {
<UtilityRow
borderType="inset-left"
onClick={selectGeneralSupport}
rightChildren={<ChevronRight />}
rightChildren={<Icon name="chevron_right" size={16} />}

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size should be 24px as per designs

subTitle={__('Get help connecting your account')}
title={__('Request support')}
/>
Expand Down
5 changes: 2 additions & 3 deletions src/views/disclosure/DataRequested.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import { useSelector } from 'react-redux'
import PropTypes from 'prop-types'

import { useTokens } from '@kyper/tokenprovider'
import { Text } from '@mxenabled/mxui'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Icon, Text } from '@mxenabled/mxui'
import { Link } from '@mui/material'

import { selectConnectConfig } from 'src/redux/reducers/configSlice'
Expand Down Expand Up @@ -97,7 +96,7 @@ export const DataRequested = (props) => {
style={styles.link}
>
{__('Other available data')}
<ChevronRight style={styles.chevron} />
<Icon name="chevron_right" size={16} />

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size again

</Link>
</SlideDown>
</Fragment>
Expand Down
8 changes: 3 additions & 5 deletions src/views/disclosure/Interstitial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ import { useSelector } from 'react-redux'
import PropTypes from 'prop-types'

import { useTokens } from '@kyper/tokenprovider'
import { Text } from '@mxenabled/mxui'
import { Icon, Text } from '@mxenabled/mxui'
import { Link as LinkIcon } from '@kyper/icon/Link'
import { Lock } from '@kyper/icon/Lock'
import { InfoOutline } from '@kyper/icon/InfoOutline'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Link, Stack } from '@mui/material'

import { PageviewInfo } from 'src/const/Analytics'
Expand Down Expand Up @@ -176,7 +175,7 @@ export const DisclosureInterstitial = React.forwardRef((props, interstitialNavRe
variant="ParagraphSmall"
>
{__('Data requested')}
<ChevronRight style={styles.chevron} />
<Icon name="chevron_right" size={16} sx={{ marginLeft: '13.02px' }} />

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a stack with spacing

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

</Link>
<Link
data-test="privacy-policy-button"
Expand All @@ -198,7 +197,7 @@ export const DisclosureInterstitial = React.forwardRef((props, interstitialNavRe
>
{_p('connect/disclosure/policy/link', 'MX Privacy Policy')}

<ChevronRight style={styles.chevron} />
<Icon name="chevron_right" size={16} sx={{ marginLeft: '13.02px' }} />

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack with spacing

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

</Link>
</Stack>
</Fragment>
Expand Down Expand Up @@ -246,7 +245,6 @@ const getStyles = (tokens) => {
marginTop: tokens.Spacing.Medium,
width: 'fit-content',
},
chevron: { marginLeft: '13.02px' },
}
}

Expand Down
5 changes: 2 additions & 3 deletions src/views/disclosure/PoweredByMX.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react'

import { useTokens } from '@kyper/tokenprovider'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Icon } from '@mxenabled/mxui'
import PropTypes from 'prop-types'

import { Button } from '@mui/material'
Expand All @@ -21,7 +21,7 @@ const PoweredByMX = ({ onClick }) => {
variant="text"
>
<PoweredByMXText />
<ChevronRight style={styles.chevron} />
<Icon name="chevron_right" size={16} sx={{ marginLeft: 4 }} />

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack with spacing

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

</Button>
)
}
Expand All @@ -36,7 +36,6 @@ const getStyles = () => {
display: 'flex',
flexDirection: 'row',
},
chevron: { marginLeft: 4 },
}
}

Expand Down
7 changes: 3 additions & 4 deletions src/views/loginError/ImpededMemberError.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import { getInstitutionLoginUrl } from 'src/utilities/Institution'
import { goToUrlLink } from 'src/utilities/global'

import { useTokens } from '@kyper/tokenprovider'
import { Text } from '@mxenabled/mxui'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Icon, Text } from '@mxenabled/mxui'
import { Link } from '@mui/material'

export const ImpededMemberError = ({
Expand Down Expand Up @@ -52,7 +51,7 @@ export const ImpededMemberError = ({
>
{__('Visit website')}
</Link>
<ChevronRight color={tokens.Color.Primary300} />
<Icon name="chevron_right" size={16} sx={{ color: tokens.Color.Primary300 }} />

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color prop or theme variable

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

</div>
</div>
</div>
Expand All @@ -66,7 +65,7 @@ export const ImpededMemberError = ({
</Text>
<div style={styles.actionArea}>
<Link onClick={onRefreshClick}>{__('Try again')}</Link>
<ChevronRight color={tokens.Color.Primary300} />
<Icon name="chevron_right" size={16} sx={{ color: tokens.Color.Primary300 }} />

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color prop or theme variable

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

</div>
</div>
</div>
Expand Down
5 changes: 2 additions & 3 deletions src/views/manualAccount/ManualAccountMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ import PropTypes from 'prop-types'
import { __ } from 'src/utilities/Intl'

import { useTokens } from '@kyper/tokenprovider'
import { Text } from '@mxenabled/mxui'
import { Icon, Text } from '@mxenabled/mxui'
import { UtilityRow } from '@kyper/utilityrow'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Check } from '@kyper/icon/Check'
import { PiggyBankOutline } from '@kyper/icon/PiggyBankOutline'
import { Document } from '@kyper/icon/Document'
Expand Down Expand Up @@ -107,7 +106,7 @@ export const ManualAccountMenu = React.forwardRef((props, ref) => {
onClick={() =>
fadeOut(ref.current, 'up', 300).then(props.handleAccountTypeSelect(account_type))
}
rightChildren={<ChevronRight />}
rightChildren={<Icon name="chevron_right" size={16} />}

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

title={AccountTypeNames[account_type]()}
/>
))}
Expand Down
11 changes: 8 additions & 3 deletions src/views/microdeposits/AccountInfo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@ import PropTypes from 'prop-types'
import _isEmpty from 'lodash/isEmpty'

import { useTokens } from '@kyper/tokenprovider'
import { Text } from '@mxenabled/mxui'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Icon, Text } from '@mxenabled/mxui'
import { TextField, SelectionBox } from 'src/privacy/input'
import { Button, RadioGroup, FormControl, FormLabel } from '@mui/material'

Expand Down Expand Up @@ -192,7 +191,13 @@ export const AccountInfo = (props) => {

<SlideDown delay={getNextDelay()}>
<ActionableUtilityRow
icon={<ChevronRight color={tokens.TextColor.ButtonLinkTertiary} size={16} />}
icon={
<Icon
name="chevron_right"
size={16}
sx={{ color: tokens.TextColor.ButtonLinkTertiary }}

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color prop or theme variable

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

/>
}
onClick={() => setShowFindDetails(true)}
text={__('Help finding your account number')}
/>
Expand Down
11 changes: 8 additions & 3 deletions src/views/microdeposits/RoutingNumber.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ import { defer } from 'rxjs'
import _isEmpty from 'lodash/isEmpty'

import { useTokens } from '@kyper/tokenprovider'
import { Text } from '@mxenabled/mxui'
import { ChevronRight } from '@kyper/icon/ChevronRight'
import { Icon, Text } from '@mxenabled/mxui'
import { TextField } from 'src/privacy/input'
import { Button } from '@mui/material'

Expand Down Expand Up @@ -224,7 +223,13 @@ export const RoutingNumber = (props) => {

<SlideDown delay={getNextDelay()}>
<ActionableUtilityRow
icon={<ChevronRight color={tokens.TextColor.ButtonLinkTertiary} size={16} />}
icon={
<Icon
name="chevron_right"
size={16}
sx={{ color: tokens.TextColor.ButtonLinkTertiary }}

@wesrisenmay-mx wesrisenmay-mx Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color prop or theme variable

@platypus801 platypus801 Jul 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size 24px

/>
}
onClick={() => setShowFindDetails(true)}
text={__('Help finding your routing number')}
/>
Expand Down
Loading