Repository navigation
Let pilots import their own SimBrief plan and check in with its estimated times - #348
Merged
Merged
Conversation
…ated times Cabin crew can now call the SimBrief import. A pilot's import is marked ready and checks the pilot in with the plan's estimated off-block, takeoff, arrival and on-block times, so the flight is theirs straight away and never shows up as another pilot's next flight. A pilot with a flight in progress is refused before SimBrief is called. Operations imports still stay in created. The departure stand can now be set until boarding starts rather than only until check-in, so a flight checked in by its import can still get one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
OpenTofu plan for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pilots no longer need operations to get a flight: a pilot imports the latest plan in their own SimBrief account and flies it straight away.
What changes
POST /api/v1/flight/create-with-simbriefaccepts theCabinCrewrole. An operations import is unchanged and stayscreated.MarkAsReadyCommandandCheckInPilotCommand. The pilot is the captain, and every check-in side effect runs: current flight, NOTOC acknowledgement, check-in travel, weather monitoring, Discord briefing. The estimated times come from the OFP'stimes.est_out/est_off/est_on/est_in, each falling back to itssched_*when the plan has no estimate. The flight's events carry theuserscope.409("A flight is already in progress. Close it before importing another plan."), checked before SimBrief is called.123456carriesest_*times a few minutes off the scheduled ones, so the scenario proves which set was used.Tests
flight.create-with-simbrief.feature:checked_inwith the plan's estimated times, and can still set the departure stand400409403scenario is goneformat(whole repo),lint,testandtest:functionalpass locally: 1433 unit tests, 1620 scenarios.Version 3.89.0.
Knowledge base: mypreflight/product#78
Web app: mypreflight/app#364, which needs this deployed first.
🤖 Generated with Claude Code