fix: Load MX before instantiating the error mock controller - #562
Merged
hellopablo merged 1 commit intoSep 8, 2026
Merged
Conversation
Error views can be rendered before the MX Router registers the MX_* autoloader (e.g. URI character filtering). Nails\Common\Controller\Base extends MX_Controller, so skip that load and error rendering fatals. Fall back to halt() if the mock controller still cannot be created.
hellopablo
deleted the
fix/errorhandler-mx-controller-early-bootstrap-develop
branch
September 8, 2026 06:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as #561 but targeting
develop.Early exceptions (before CodeIgniter's Router loads) can cascade into a second fatal when rendering the error view, because
Nails\Common\Controller\BaseextendsMX_ControllerandMX/Modules.phphas not registered theMX_*autoloader yet.Change
MX/Modules.phpinErrorHandler::instantiateMockController()whenMX_Controlleris not already loaded.instantiateMockController()intry/catch (\Throwable)and fall back tohalt().Does not change URI filtering: production still
halt()s disallowed characters as 404; non-prod still bubbles.