Skip to content

fix: Load MX before instantiating the error mock controller #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hellopablo merged 1 commit into from
Sep 8, 2026
Merged

fix: Load MX before instantiating the error mock controller #562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/Common/Service/ErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,16 @@ public static function renderErrorView(
);
}

static::instantiateMockController();
try {
static::instantiateMockController();
} catch (\Throwable $e) {
static::halt(
ArrayHelper::get('sMessage', $aData) ?: $e->getMessage(),
ArrayHelper::get('sSubject', $aData),
$iCode,
$aTrace
);
}

// Flush the output buffer
if ($bFlushBuffer) {
Expand Down Expand Up @@ -670,6 +679,14 @@ protected static function instantiateMockController()

require_once BASEPATH . 'core/Controller.php';

// URI filtering (and other early failures) can occur before the MX
// Router is loaded. Nails\Common\Controller\Base extends MX_Controller,
// so the mock controller used to render error views must ensure MX is
// available. Modules.php registers the MX_* autoloader.
if (!class_exists('MX_Controller', false)) {
require_once Config::get('NAILS_COMMON_PATH') . 'MX/Modules.php';
}

// Match pocketarc/codeigniter system/core/CodeIgniter.php:
// Security requires $charset; Input requires the Security instance.
$sCharset = strtoupper((string) config_item('charset'));
Expand Down
Loading