Skip to content

refactor(media): split the plyr specifics out of the media player composable - #127

Merged
skjnldsv merged 1 commit into
mainfrom
feature/media-player-adapter
Oct 7, 2026
Merged

skjnldsv merged 1 commit into
mainfrom
feature/media-player-adapter

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Plyr is deprecated (security fixes only), so I'm moving the player to Video.js 10 in #128. This splits usePlyrPlayer first: useMediaPlayer keeps our logic, usePlyrAdapter keeps the Plyr bits, so the swap only replaces the adapter.

No behaviour change, the tests only had their imports updated.

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

…posable

Prepares the move from plyr, now deprecated, to Video.js: the swap
then only needs another adapter.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv added status: review Waiting for reviews type: refactor ♻️ Refactor code (not a bug fix, not a feature just refactoring) AI assisted labels Oct 7, 2026
@skjnldsv skjnldsv self-assigned this Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.50549% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.39%. Comparing base (f8edb26) to head (038484d).
⚠️ Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
lib/composables/usePlyrAdapter.ts 95.65% 3 Missing ⚠️
lib/composables/useMediaPlayer.ts 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   91.05%   91.39%   +0.33%     
==========================================
  Files          41       42       +1     
  Lines        3421     3556     +135     
  Branches      790      817      +27     
==========================================
+ Hits         3115     3250     +135     
+ Misses        288      287       -1     
- Partials       18       19       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skjnldsv
skjnldsv merged commit 3bc37fb into main Oct 7, 2026
21 checks passed
@skjnldsv
skjnldsv deleted the feature/media-player-adapter branch October 7, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI assisted status: review Waiting for reviews type: refactor ♻️ Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant