Repository navigation
refactor(media): split the plyr specifics out of the media player composable - #127
Merged
Merged
Conversation
…posable Prepares the move from plyr, now deprecated, to Video.js: the swap then only needs another adapter. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 91.05% 91.39% +0.33%
==========================================
Files 41 42 +1
Lines 3421 3556 +135
Branches 790 817 +27
==========================================
+ Hits 3115 3250 +135
+ Misses 288 287 -1
- Partials 18 19 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plyr is deprecated (security fixes only), so I'm moving the player to Video.js 10 in #128. This splits
usePlyrPlayerfirst:useMediaPlayerkeeps our logic,usePlyrAdapterkeeps the Plyr bits, so the swap only replaces the adapter.No behaviour change, the tests only had their imports updated.
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.