Repository navigation
feat(media): play video and audio with Video.js instead of plyr - #128
Merged
Merged
Conversation
skjnldsv
added
status: developing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
+ Coverage 91.39% 92.82% +1.42%
==========================================
Files 42 47 +5
Lines 3556 4069 +513
Branches 817 813 -4
==========================================
+ Hits 3250 3777 +527
+ Misses 287 273 -14
Partials 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
skjnldsv
marked this pull request as ready for review
October 7, 2026 09:11
Plyr is deprecated and only gets security fixes. The Video.js skin source is vendored unchanged, its tokens set to the Nextcloud theme. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feature/videojs
branch
from
October 7, 2026 09:15
244a5f2 to
55b6e38
Compare
susnux
approved these changes
Oct 7, 2026
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plyr is deprecated, so this moves video and audio to Video.js 10, bundled from npm. Stacked on #127.
The skin is Video.js's own source, copied unchanged into
lib/components/videojs/vendor. Our colours only live innextcloud.css, so an update is a copy over.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.