Repository navigation
paper: make Section VIII reproducible and recompute the constants independently - #114
Conversation
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 15 minutes. View limit details
|
[Low impact] The changes affect reproducibility materials and paper text, not the library’s runtime behavior. Correct the input precision and refresh the affected results before merging. Findings
SummaryAdds repeatable arithmetic tests and a separate recomputation of the paper’s constants, then updates Section VIII to cite their saved results.
The small-precision campaign builds its operands at the previous test’s precision, so its stated coverage and saved results need correction. Reviews (1) · Last reviewed commit: "paper: rebuild the PDF" · Reviewed by Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
=======================================
Coverage 95.95% 95.95%
=======================================
Files 22 22
Lines 14013 14013
=======================================
Hits 13446 13446
Misses 567 567 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
New code in paper/review, written from the appendix at 187ce44 before reading the paper's constants scripts, recomputes the constants of the sloppy multiply, the trigonometric functions, exp, ln and the binary64 logarithm.
campaign.py reruns the tests of Theorems 9, 15 and 19, Corollary 18 and Proposition 24 on the emulator: bit for bit against the crate at p = 53, exhaustive families at small precision, and Proposition 24's inputs, each with controls. acc_check gains the modes it needs, and the outputs are stored in paper/campaign.
The review programs now compare with the values the paper quotes rounded up and print their own rounded up, and their outputs are stored in review/out. indep_exp.py and indep_log.py, written from an earlier text of the appendix, are removed.
sloppy_consts.py had no stored output, and no script printed the construction's ratio to its leading term and to the bound at K = 64 that the accumulator's remark quotes.
The maxima of the crate's tests on random arguments, the size of the terms a Fast2Sum pass drops and the accumulator's growth per deposit had no script or stored output in the repository. The remark on the construction now quotes what acc_check.py prints.
The section described a campaign and reviews whose code is not in the repository, and narrated the paper's revisions. It now quotes the outputs of campaign.py and of the recomputations in review/, the random-operand error comes from the campaign, and How this work was done is three sentences that name the recomputation.
The PDF of the rewritten Section VIII.
small() built its families while the emulator was still at the precision of the test before, so the operands were rounded to 3 and 5 bits and many coincided. The precision is now set first, the family is checked for duplicates, and small.txt is regenerated: every pair is still within its bound, the largest at 0.43 of it.
Lambda, beta, alpha, gamma, zeta, pi and f each stood for several things, and R and Delta were absolute in Lemmas 11 and 13 and normalized in Theorem 14. The appendices rename all but one use of each, write the number pi upright, and the scripts' docstrings name the paper's symbols.
Each of these theorems stated a recursion for computing a bound. The recursion now stands in a paragraph before the theorem, which states the bound and its computed value. The numbering is unchanged.
Algorithm 2 took c_0 to c_N with N at most n, and Appendix B and Theorem 9 take N terms c_0 to c_(N-1) with N at most n + 1.
The text had its last parts near 2^(-2j-320). The last of eight parts of 1 - r^2/2 is about u^6 r^2 / 2, near 2^(-2j-319).
The unit, the crate's OD::EPS, was used in a caption and a remark and never defined.
The trigonometric functions run DWTimesDW3 and exp and ln DWTimesDW2. The text now says how they differ and that each appendix's constants are those of its product.
Table I named the operand x for the sine, cosine and tangent and a elsewhere, and Table II listed the operations in another order than Table I.
Shewchuk for expansions, Moller and Knuth for TwoSum, Sterbenz for the exact subtractions and Payne and Hanek for the reduction of large arguments were used without a reference. The list is now in order of first citation, with page ranges for the three ACM articles, the Universal pull request's full title, the crate's version and commit, and the QD authors' release.
The number 3.5 is that of the HAL preprint, as the crate's comment says. The published article could not be opened to confirm its numbering.
Assume with a bare reference printed as Assume 6, and IEEEtran's paragraph headings printed labels a) to d) that nothing refers to. The appendices now write Under Assumption 6 and use an unlabeled run-in heading.
Figure 1's labels were about 5 pt after scaling, the appendix started mid-column, Table V floated two pages past its text, and two long inline chains were stretched across the column. The figure is redrawn larger, the appendix starts on a new page, the table moves before its section, and the chains are displays.
Lemma 33 wrote f_k for the real that the expansion F_k approximates, another use of f. It is now F_k with the superscript e that the lemma's other exact values carry.
The PDF of the notation, references and layout changes.
c0065ee to
f85b7d0
Compare
Stacked on #112. Makes Section VIII true from the repository: findings 12, 13, 15, 17, 41 and 46.
The campaign (finding 12)
paper/campaign.pyreruns the tests of Theorems 9, 15 and 19, Corollary 18 and Proposition 24 onfpemu.py, and takes multidouble's bits throughaccumulator/acc_check, which gains the modesaddn8,addf8,mulf8,mul8anddiv8. Its outputs are stored inpaper/campaign/, and Section VIII quotes only what they print.bitssmallsharpThe independent recomputation (finding 13)
paper/review/now holds programs I wrote from the appendix's text at 187ce44 before openingsloppy_consts.py,trig_consts.py,explog_consts.pyor the earlierreview/indep_*.py. They sharegop.py(Lemmas 11 and 13, Theorems 14, 19, 21 and 27 from the text) and no code with the paper's scripts.Every value agrees. The recomputation of Theorem 35 evaluates all 212 buckets where the script takes one per pair of series lengths, and it is what showed that the paper quoted C below its computed value (3.163167 for 3.1631674), which #111 corrects. Theorem 42's takes the double-word start's constants from the statement of Proposition 44. Each program has a control that must print FAIL. The earlier
indep_exp.pyandindep_log.py, written from an earlier text, are removed.What is cut, and why
No committed script prints these, so they are gone from the text (findings 15 and 17):
cargo teston random arguments: 0.01 u^8 for the operations (now the campaign's 0.0064 u^8 on dense random operands), 0.48 u^8, 1.82 u^2 and 4.07 u^2 for the trigonometric functions, 0.25 u^8, 0.0070 u^8, 1.04 u^2, 1.27 u^2 and 3.491 u for exp, ln and the binary64 logarithm;sloppy_consts.txtis now stored, andacc_check.pyprints the construction's ratios at K = 64 that Remark 29 quotes.Text (findings 41 and 46)
Section VIII says what each script checks, without the history of the review. "How this work was done" is three sentences and names the recomputation of Appendices F to H and K to M.
No theorem's statement or constant changes here.