Repository navigation
fix(notify): scope run/jobs lookups to github.repository with optional run-token - #23
Merged
Merged
Conversation
…esolvable target-sha" This reverts commit 99331c5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The Slack card is missing
DURATIONandFAILED ATwhen the caller setstarget-repofor cross-org attribution.notify@v4.0.0calls the Actions API ontarget-repoto fill those two rows — but Actions runs only exist ingithub.repository. So the calls 404, get swallowed by2>/dev/null, and both rows silently disappear.Same-repo callers (
target-repo == github.repository) never saw it.Fix
github.repository(that's where the run actually is — hard-coded, not overridable).run-tokenfor those two calls; falls back togithub-token, so existing callers are byte-identical.${{ }}inside the composite action'sdescription:block.Fully additive — no consumer has to change to keep working.