Repository navigation
Conversation
Brings AiDotNet.Tensors #1069: SimdKernels.SigmoidUnsafe runs the same Padé kernel on Intel and AMD (an Intel-only table sigmoid made RepViTSAM and EfficientSAM's training invariants fail on Intel runners only), and sigmoid(+/-inf) is no longer NaN. Managed and native packages move together. 0.133.1 renamed DeferredArrayMaterializer to HostSync with the same TryMaterialize/Register/Remove; the four sharded-training call sites and their tests follow, matching #2267's rename hunk for hunk. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: ooples/AiDotNet/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Commit messages auto-fixedOne or more commit messages did not follow Conventional Commits, so they were rewritten to comply (subject case, header length ≤ 100, valid type). Each commit and its diff were preserved — no squashing. The branch was force-pushed with the corrected messages. If you have local work on this branch, run |
e1df187 to
a96ccb6
Compare
|
Deployment failed for project aidotnet_website with the following error: Learn More: https://vercel.com/franklins-projects-02a0b5a0?upgradeToPro=build-rate-limit |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The lockstep package bump is valid and all affected API references were consistently migrated.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the tensor stack to 0.133.2 for CPU-independent sigmoid behavior and adopts the renamed synchronization API.
Changes:
- Bumps all tensor/native packages in lockstep.
- Replaces
DeferredArrayMaterializercalls withHostSync.
| File | Description |
|---|---|
Directory.Packages.props |
Updates tensor packages to 0.133.2. |
src/DistributedTraining/ShardedOptimizerBase.cs |
Migrates optimizer offloading to HostSync. |
src/DistributedTraining/ShardedModelBase.cs |
Migrates model offloading to HostSync. |
tests/AiDotNet.Tests/UnitTests/DistributedTraining/CpuOffloadShardingConfigTests.cs |
Updates synchronization tests for the renamed API. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
On hold, two failures:
|
|
Superseded: master is on AiDotNet.Tensors 0.134.0 (bumped via #2276), which contains everything 0.133.2 brought. Merging master here would leave this PR with no changes. |
Why
Several PRs have a shard that fails only on Intel runners: RepViTSAM (#2277) and EfficientSAM (#2272, #2269). Bisected on hosted runners, the cause is Tensors' Intel-only table sigmoid. It is accurate, but numerically different from the Padé kernel AMD runs, and AdamW's start-up transient amplifies the difference. AiDotNet.Tensors #1069, released in 0.133.2, puts every vendor on one kernel and also makes
sigmoid(±inf)saturate instead of returning NaN.Changes
AiDotNet.Tensorsand the threeAiDotNet.Native.*packages from 0.133.0 to 0.133.2, together.DeferredArrayMaterializertoHostSync, with the sameTryMaterialize/Register/Remove. The four sharded-training call sites andCpuOffloadShardingConfigTestsfollow. The hunks match fix: fused training matches eager - optimizer formulas, persistent fused steps, full trainable set #2267's rename exactly, so they merge cleanly whichever lands first; only the version line will conflict.Verified locally
CpuOffloadShardingConfigTests: 11/11 passed.UnitTests.Optimizersplus the EfficientSAM and RepViTSAM training invariants: 346/346 passed (AMD).The full matrix runs here, since this is a package bump. The Intel-runner behaviour shows on any shard that lands on an Intel CPU, where these models previously failed.
Overlap: #2267 and #2254 bump to 0.133.1. Once this merges, they can drop their version change and take 0.133.2 from master.
🤖 Generated with Claude Code