oadp: split kubevirt e2e job (5.0) and add Claude failure analysis to kdm-controller/plugin - #84337
Conversation
ci/prow/5.0-e2e-test-kubevirt-aws was hitting Prow's 2h step timeout running both the non-kdm CSI virt suite and the kdm suite serially (openshift/oadp-operator#2413). openshift/oadp-operator#2423 makes TEST_VIRT_KDM=false explicitly exclude kdm specs while leaving existing jobs that don't set it unaffected. Split the presubmit into two parallel jobs, matching the naming used for the kdm-controller repo's own split job: - virt-nokdm-e2e-test-aws: TEST_VIRT=true TEST_VIRT_KDM=false - virt-kdm-e2e-test-aws: TEST_VIRT_KDM=true Each comfortably clears the 2h default, and CI feedback now arrives in parallel instead of serially. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
/pj-rehearse pull-ci-openshift-oadp-operator-oadp-dev-5.0-virt-nokdm-e2e-test-aws pull-ci-openshift-oadp-operator-oadp-dev-5.0-virt-kdm-e2e-test-aws Note Responses generated with Claude |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe AWS virtualization CI configuration now separates KDM-disabled and KDM-enabled tests. OADP controller and plugin jobs also configure test metadata and run ChangesAWS virtualization CI
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change splits the KubeVirt end-to-end workload into separate jobs and adds failure analysis to related jobs without introducing an actionable merge-blocking risk; it is merge-ready after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS. The pull request changes only CI YAML configuration and generated Prow YAML; it adds no Ginkgo Full details: Test Structure And QualityExplanation PASS: The pull request changes only six YAML CI configuration files. The diff contains no Go test files or Ginkgo test code, and no Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds or changes CI YAML job definitions only. The verified PR diff contains no added Go files and no new Ginkgo declarations ( Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only six CI YAML files. The diff adds no Go or other test source files and no Ginkgo declarations such as Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — The PR changes only ci-operator configuration and generated Prow job YAML. The changes rename/split E2E jobs, set environment variables, add a Claude post-step, and add CI pod wiring. No deployment manifest, operator/controller source, or scheduling constraint is added. The changed lines contain no affinity, topology spread, nodeSelector, control-plane/worker targeting, tolerations, replica-count logic, or PDB settings. Therefore none of the custom check's topology-failure conditions applies. Full details: Ote Binary Stdout ContractExplanation PASS. The pull request changes six CI YAML files only; it adds or updates job configuration, environment variables, shell commands, and generated Prow jobs. It does not change an OTE binary or suite setup code. No changed lines contain process-level stdout patterns such as Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS — The PR adds no Ginkgo test code or test files. The diff contains only CI YAML changes, and the new jobs invoke the existing Full details: No-Weak-CryptoExplanation PASS: The complete PR diff adds CI YAML metadata, job names, Make commands, environment variables, the existing Full details: Container-PrivilegesExplanation No changed container or Kubernetes manifest introduces a listed privilege. The PR diff adds CI image references, environment variables, post-step references, and job renames. The generated Prow job changes contain no Full details: No-Sensitive-Data-In-LogsExplanation No changed line logs a password, token, API key, PII, session ID, hostname, or customer data. The PR adds CI configuration, test names, branch names, and references an existing ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/pj-rehearse abort Note Responses generated with Claude |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…post-step Wires the Claude-based e2e failure analysis post-step (added for oadp-operator in openshift#83957) into the kubevirt-datamover virt-kdm-e2e-test-aws jobs too, for both oadp-1.6 and oadp-dev configs of kubevirt-datamover-controller and kubevirt-datamover-plugin: - base_images.claude-ai-helpers (ci namespace, shared image) - steps.env.OADP_BRANCH / TEST_NAME (per config file) - steps.post: oadp-analyze-e2e-failure ref, before the ipi-aws-post teardown chain Reuses the existing OADP-scoped ref as-is since these jobs install and test against oadp-operator itself (test-oadp-operator base image, oadp-operator e2e suite via TEST_VIRT_KDM=true). Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-migtools-kubevirt-datamover-controller-oadp-1.6-virt-kdm-e2e-test-aws pull-ci-migtools-kubevirt-datamover-plugin-oadp-1.6-virt-kdm-e2e-test-aws (openshift/oadp-operator#2424, cherry-pick of openshift/oadp-operator#2423 to oadp-1.6, has merged — rehearsing the oadp-1.6 kdm-controller/plugin jobs now. Holding the 5.0/oadp-dev jobs until openshift/oadp-operator#2423 itself merges.) Note Responses generated with Claude |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@kaovilai: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
746f261
into
openshift:main
…p-1.6) Same fix as the earlier oadp-dev/5.0 split (openshift#84337), now backported to oadp-1.6's own e2e-test-kubevirt-aws presubmit across all three variants (4.22, 4.23, 5.0). openshift/oadp-operator#2424 (cherry-pick of openshift#2423 to oadp-1.6) gave this branch's Makefile the same TEST_VIRT_KDM support, so the split is safe here too. - virt-nokdm-e2e-test-aws: TEST_VIRT=true TEST_VIRT_KDM=false - virt-kdm-e2e-test-aws: TEST_VIRT_KDM=true Prompted by openshift/oadp-operator#2427 (unpends two more kdm restore specs on oadp-1.6), which risks pushing the still-unsplit job back over the 2h step timeout the same way oadp-dev/5.0 hit it originally. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
…p-1.6) (#84490) Same fix as the earlier oadp-dev/5.0 split (#84337), now backported to oadp-1.6's own e2e-test-kubevirt-aws presubmit across all three variants (4.22, 4.23, 5.0). openshift/oadp-operator#2424 (cherry-pick of #2423 to oadp-1.6) gave this branch's Makefile the same TEST_VIRT_KDM support, so the split is safe here too. - virt-nokdm-e2e-test-aws: TEST_VIRT=true TEST_VIRT_KDM=false - virt-kdm-e2e-test-aws: TEST_VIRT_KDM=true Prompted by openshift/oadp-operator#2427 (unpends two more kdm restore specs on oadp-1.6), which risks pushing the still-unsplit job back over the 2h step timeout the same way oadp-dev/5.0 hit it originally. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
…jobs (#84592) Same split already applied to the presubmits (#84337, #84490), now extended to the daily periodics we'd deliberately left unsplit at the time. All branches now have TEST_VIRT_KDM support (openshift/oadp-operator#2423, #2424), so the periodics are safe to split too: - virt-nokdm-e2e-test-aws-periodic: TEST_VIRT=true TEST_VIRT_KDM=false - virt-kdm-e2e-test-aws-periodic: TEST_VIRT_KDM=true Applied to all 5 variant configs that carry this periodic: oadp-dev (5.0, 5.1) and oadp-1.6 (4.22, 4.23, 5.0). Both split jobs keep the same cron schedule and Slack reporter_config as the job they replace. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
Summary
ci/prow/5.0-e2e-test-kubevirt-awswas hitting Prow's 2h step timeout running both the non-kdm CSI virt suite and the kdm suite serially (openshift/oadp-operator#2413). openshift/oadp-operator#2423 makesTEST_VIRT_KDM=falseexplicitly exclude kdm specs while leaving existing jobs that don't set it unaffected (no regression).Splits the
oadp-dev__5.0presubmit into two parallel jobs, matching the naming used for the kdm-controller repo's own split job (virt-kdm-e2e-test-aws):virt-nokdm-e2e-test-aws:make TEST_VIRT=true TEST_VIRT_KDM=false test-e2evirt-kdm-e2e-test-aws:make TEST_VIRT_KDM=true test-e2eEach comfortably clears the 2h default, and CI feedback now arrives in parallel instead of serially.
Also wires the Claude-based
oadp-analyze-e2e-failurepost-step (added for oadp-operator in #83957) into thekubevirt-datamover-controller/kubevirt-datamover-pluginvirt-kdm-e2e-test-awsjobs (bothoadp-1.6andoadp-devconfigs), for the same failure-analysis coverage.Depends on:
TEST_VIRT_KDMsupport) — held in draft until then.Note
Responses generated with Claude
Summary by CodeRabbit
oadp-dev__5.0KubeVirt AWS presubmit into parallel KDM and non-KDM jobs to avoid Prow’s two-hour step timeout.oadp-1.6andoadp-dev.