Repository navigation
Add SingleLineString to reject line breaks in RFD attribute values - #615
Merged
Merged
Conversation
notpeter
changed the title
Collaborator
Author
|
@claude review |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
notpeter
added a commit
that referenced
this pull request
Nov 12, 2026
- `POST /rfd/{number}/attr/{attr}`: Validate permissions before
inspecting user provided data
- Reject attributes containing newlines (`\r` or `\n`)
- Limit `{authors}` expansion size to prevent DoS from malicious input
- See also: #615
> 🤖 robot:
> An anonymous internet caller can crash the rfd-api process with one
request of up to 1 MiB, and can repeat it after every restart. The
request must target an RFD the caller can read, such as a public one,
whose stored document has no :authors: header line before the edited
attribute.
Claude Link (team-shared):
https://claude.ai/code/cshk_01Q5Ej2cHBc7wgaksc9BPkaiPgvaeaJszgNYbzxzfE9Cj5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
SingleLineStringwhich is a string that does not contain\ror\n.Use it for
RfdAttrValue.valueandupdate_{state,discussion,labels}This prevents attribute updates from introducing additional lines of document header.
SDK type changes from String to RfdAttrValueValue, but does not impact callers.
When clients pick up the new SDK it can be validated client side too (e.g. with Zod).