feat: map the Switch, Camera, Sensor and Cellular Gateway members from the 1.74.0 gap report - #421
Open
danielabbatt wants to merge 1 commit into
Conversation
…m the 1.74.0 gap report
Twenty-two members the v1.74.0 spec documents that the models lacked, the
fifth per-area batch, plus eight corrections to members that could never
bind: ConfigTemplateSwitchProfilePortDot3az mapped "dot3az" for "enabled",
NetworksSwitchDhcpV4ServersSeenLastPacketSourceIpv4 mapped "ipv4" for
"address", EsimsServiceProvidersItemLogo mapped "logo" for "url",
EsimsServiceProvidersAccounts.Items was a list of a type that is itself an
{items, meta} wrapper, CameraLive.Zones was fixed to a single "0" zone where
the API keys by zone ID, ZoneData.Person had no [DataMember] inside a
[DataContract] class, SensorMetrics lacked no2/o3/pm10 so those readings
threw on deserialization, and IOrganizationSwitches carried a duplicate
GetOrganizationSwitchPortsTopologyDiscoveryByDeviceAsync overload wired to
the usage-history path, which is removed.
SwitchCameraSensorCellularMemberTests covers the new members and the
corrections.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
🟢 Metrics 9 complexity
Metric Results Complexity 9
AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #420 → #419 → #418 → #417 → #416 → #415
Base is
feat/map-wireless-members. Merge the chain in order with merge commits, then retarget this tomain. Changelog label1.74.17assumes that.What
Fifth per-area batch from
gap-report-v1.74.0.md: 22 members across Switch, Camera, Sensor and Cellular Gateway (the four small areas, combined so the PR is still a sensible size).AlternateManagementInterface.UseOobMgmt,ConfigOverrides.VoiceVlan,SwitchPort.StpPortFastTrunk,ConfigTemplateSwitchProfilePort.StpPortFastTrunk,StackDevice.ProductType,SwitchPortsUsageHistoryByDeviceByIntervalItem.SerialPermissionLevel+PermissionScopeon all threeCameraRoleApplied*types,Tagon…OrgWideNo2,O3,Pm10onSensorReadingHistoricandSensorReadingLatestReading(reusingSensorMetricConcentration)NetworkCellularGatewayEsimsInventoryItemDevice.StatusEight corrections — none of these ever bound
ConfigTemplateSwitchProfilePortDot3az.Dot3az←dot3azEnabled←enabled(matchesSwitchPortDot3az)NetworksSwitchDhcpV4ServersSeenLastPacketSourceIpv4.Ipv4←ipv4Address←addressEsimsServiceProvidersItemLogo.Logo←logoUrl←urlEsimsServiceProvidersAccounts.Items : List<EsimsServiceProvidersAccountsItem>— the item type is itself an{items, meta}wrapperList<NetworkCellularGatewayEsimsServiceProviderAccount>; old item type[Obsolete]CameraLive.Zones : Zoneswith one fixed"0"memberDictionary<string, ZoneData>keyed by zone ID;Zones[Obsolete]ZoneData.Personwith no[DataMember]inside a[DataContract]class (Newtonsoft ignores it)[DataMember(Name = "person")],int?SensorMetricswithoutno2/o3/pm10— a reading with one of those threw (Requested value 'pm10' was not found)IOrganizationSwitches.GetOrganizationSwitchPortsTopologyDiscoveryByDeviceAsync(…13 filter params…)with[Get(".../switch/ports/usage/history/byDevice/byInterval")]— a copy of the usage-history method renamed, so it fetched usage history into the topology type.../topology/discovery/byDevicepath remains. No callers outsideInterfaces.Verification
All edited files kept their BOM state.