Skip to content

feat: map the Switch, Camera, Sensor and Cellular Gateway members from the 1.74.0 gap report - #421

Open
danielabbatt wants to merge 1 commit into
feat/map-wireless-membersfrom
feat/map-switch-camera-sensor-cellular-members
Open

feat: map the Switch, Camera, Sensor and Cellular Gateway members from the 1.74.0 gap report#421
danielabbatt wants to merge 1 commit into
feat/map-wireless-membersfrom
feat/map-switch-camera-sensor-cellular-members

Conversation

@danielabbatt

Copy link
Copy Markdown
Contributor

Stacked on #420#419#418#417#416#415

Base is feat/map-wireless-members. Merge the chain in order with merge commits, then retarget this to main. Changelog label 1.74.17 assumes that.

What

Fifth per-area batch from gap-report-v1.74.0.md: 22 members across Switch, Camera, Sensor and Cellular Gateway (the four small areas, combined so the PR is still a sensible size).

Area Added
Switch AlternateManagementInterface.UseOobMgmt, ConfigOverrides.VoiceVlan, SwitchPort.StpPortFastTrunk, ConfigTemplateSwitchProfilePort.StpPortFastTrunk, StackDevice.ProductType, SwitchPortsUsageHistoryByDeviceByIntervalItem.Serial
Camera PermissionLevel + PermissionScope on all three CameraRoleApplied* types, Tag on …OrgWide
Sensor No2, O3, Pm10 on SensorReadingHistoric and SensorReadingLatestReading (reusing SensorMetricConcentration)
Cellular Gateway NetworkCellularGatewayEsimsInventoryItemDevice.Status

Eight corrections — none of these ever bound

Was Now
ConfigTemplateSwitchProfilePortDot3az.Dot3azdot3az Enabledenabled (matches SwitchPortDot3az)
NetworksSwitchDhcpV4ServersSeenLastPacketSourceIpv4.Ipv4ipv4 Addressaddress
EsimsServiceProvidersItemLogo.Logologo Urlurl
EsimsServiceProvidersAccounts.Items : List<EsimsServiceProvidersAccountsItem> — the item type is itself an {items, meta} wrapper List<NetworkCellularGatewayEsimsServiceProviderAccount>; old item type [Obsolete]
CameraLive.Zones : Zones with one fixed "0" member Dictionary<string, ZoneData> keyed by zone ID; Zones [Obsolete]
ZoneData.Person with no [DataMember] inside a [DataContract] class (Newtonsoft ignores it) [DataMember(Name = "person")], int?
SensorMetrics without no2/o3/pm10 — a reading with one of those threw (Requested value 'pm10' was not found) three values added; found by the new test
IOrganizationSwitches.GetOrganizationSwitchPortsTopologyDiscoveryByDeviceAsync(…13 filter params…) with [Get(".../switch/ports/usage/history/byDevice/byInterval")] — a copy of the usage-history method renamed, so it fetched usage history into the topology type removed; the single-parameter overload with the correct .../topology/discovery/byDevice path remains. No callers outside Interfaces.

Verification

dotnet build Meraki.Api.slnx -c Debug   Build succeeded, 0 Error(s), 6 pre-existing CS0618 warnings
Meraki.Api.Test (Data namespace)        Total: 56, Errors: 0, Failed: 0   (8 new in SwitchCameraSensorCellularMemberTests)
Meraki.Api.Test (Workflows)             Total: 12, Errors: 0, Failed: 0

All edited files kept their BOM state.

…m the 1.74.0 gap report

Twenty-two members the v1.74.0 spec documents that the models lacked, the
fifth per-area batch, plus eight corrections to members that could never
bind: ConfigTemplateSwitchProfilePortDot3az mapped "dot3az" for "enabled",
NetworksSwitchDhcpV4ServersSeenLastPacketSourceIpv4 mapped "ipv4" for
"address", EsimsServiceProvidersItemLogo mapped "logo" for "url",
EsimsServiceProvidersAccounts.Items was a list of a type that is itself an
{items, meta} wrapper, CameraLive.Zones was fixed to a single "0" zone where
the API keys by zone ID, ZoneData.Person had no [DataMember] inside a
[DataContract] class, SensorMetrics lacked no2/o3/pm10 so those readings
threw on deserialization, and IOrganizationSwitches carried a duplicate
GetOrganizationSwitchPortsTopologyDiscoveryByDeviceAsync overload wired to
the usage-history path, which is removed.

SwitchCameraSensorCellularMemberTests covers the new members and the
corrections.
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

🟢 Metrics 9 complexity

Metric Results
Complexity 9

View in Codacy

AI Reviewer: run a review on demand. To trigger the first review automatically, go to your organization or repository integration settings. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant