You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Fix NU5033: use the MIT licence expression only - #5
main's build has been red because the csproj sets both PackageLicenseExpression (MIT) and PackageLicenseFile (lgpl-3.0.txt), which NuGet rejects with NU5033.
This removes PackageLicenseFile (and the empty PackageLicenseUrl) and keeps MIT, as chosen by the repo owner. lgpl-3.0.txt is still packed as a notice file for the vendored EPPlus code.
Verified locally: PanoramicData.EPPlus.csproj builds in Release with no NU5033.
The csproj set both PackageLicenseExpression (MIT) and PackageLicenseFile
(lgpl-3.0.txt), which NuGet rejects with NU5033 and which has kept main's
build red. Keep the MIT expression the owner chose; lgpl-3.0.txt is still
packed as a notice for the vendored EPPlus code.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
No blocking implementation issues were identified, and Codacy reports the changes are up to standards. The required Release build and package-content validations are not represented by automated tests.
About this PR
Add automated build/pack validation for the license metadata and notice-file requirements; local Release build verification is not represented in repository tests.
Test suggestions
Build the project in Release configuration and verify no NU5033 warning or error occurs.
Pack the project and verify the MIT license expression is present without PackageLicenseFile or PackageLicenseUrl.
Pack the project and verify lgpl-3.0.txt remains included as a notice file.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Build the project in Release configuration and verify no NU5033 warning or error occurs.
2. Pack the project and verify the MIT license expression is present without PackageLicenseFile or PackageLicenseUrl.
3. Pack the project and verify lgpl-3.0.txt remains included as a notice file.
Reading a picture back uses System.Drawing, and ExcelPicture's loading
constructor deliberately throws PlatformNotSupportedException where that is
unsupported, so the reopen half of this test failed on the Linux CI runner.
Add and save are still asserted everywhere; on non-Windows the test now asserts
the documented limit instead of failing. The Windows path is unchanged.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The suite exercises System.Drawing, which is Windows-only, and on the Linux runner
DTS_FailingTests.DeleteWorksheetWithReferencedImage hangs the test host until the
5 minute blame timeout aborts the run. The exclusions in this workflow were
established on Windows, so run the job there. The publish job stays on Linux.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
It asserts ISO text for the built-in mm-dd-yy format, which renders in the current
culture; the en-US runner produces 3/7/2019. Listed alongside the other
environment-dependent exclusions, with the reason in the workflow.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
main's build has been red because the csproj sets both PackageLicenseExpression (MIT) and PackageLicenseFile (lgpl-3.0.txt), which NuGet rejects with NU5033.
This removes PackageLicenseFile (and the empty PackageLicenseUrl) and keeps MIT, as chosen by the repo owner. lgpl-3.0.txt is still packed as a notice file for the vendored EPPlus code.
Verified locally: PanoramicData.EPPlus.csproj builds in Release with no NU5033.
🤖 Generated with Claude Code