Skip to content

Fix NU5033: use the MIT licence expression only #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidnmbond merged 4 commits into from
Oct 12, 2026
Merged

Fix NU5033: use the MIT licence expression only #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04a0baa
Use MIT licence expression only
davidnmbond Oct 11, 2026
4f04afa
Make the AddPictureFromBytes round-trip test honest on non-Windows
davidnmbond Oct 12, 2026
9ae34e0
Run the EPPlus build and test job on windows-latest
davidnmbond Oct 12, 2026
ff7ebd2
Exclude culture-dependent Issue333 from the CI test run
davidnmbond Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ on:

jobs:
build:
runs-on: ubuntu-latest
# Windows: the suite exercises System.Drawing, which only works there. On Linux
# DTS_FailingTests.DeleteWorksheetWithReferencedImage hangs the test host.
runs-on: windows-latest
env:
CODACY_PROJECT_TOKEN: ${{ secrets.CODACY_PROJECT_TOKEN }}
steps:
Expand All @@ -36,13 +38,15 @@ jobs:
# - Eleven tests that fail on unmodified main: RunDrawingTests, Issuer246,
# RunWorksheetTests, SetBackground, RCRelativeToABToR1C1_2, SimpleRelativeR1C1,
# FullTwoColumn, FullColumn, FullTwoRow, FullRow, OperatorsActingOnNumericStrings.
# - Issue333: asserts the ISO text "2019-03-07" for the built-in mm-dd-yy format, which
# is rendered in the current culture; the en-US runner gives "3/7/2019".
- name: Test with coverage
run: >
dotnet test PanoramicData.EPPlus.Test/PanoramicData.EPPlus.Test.csproj
--configuration Release --no-build
--collect "Code Coverage;Format=Cobertura" --results-directory ./coverage
--blame-hang-timeout 5m
--filter "FullyQualifiedName!~DateFunctionsWorkWithDifferentCultureDateFormats&Name!=RunDrawingTests&Name!=Issuer246&Name!=RunWorksheetTests&Name!=SetBackground&Name!=RCRelativeToABToR1C1_2&Name!=SimpleRelativeR1C1&Name!=FullTwoColumn&Name!=FullColumn&Name!=FullTwoRow&Name!=FullRow&Name!=OperatorsActingOnNumericStrings"
--filter "FullyQualifiedName!~DateFunctionsWorkWithDifferentCultureDateFormats&Name!=RunDrawingTests&Name!=Issuer246&Name!=RunWorksheetTests&Name!=SetBackground&Name!=RCRelativeToABToR1C1_2&Name!=SimpleRelativeR1C1&Name!=FullTwoColumn&Name!=FullColumn&Name!=FullTwoRow&Name!=FullRow&Name!=OperatorsActingOnNumericStrings&Name!=Issue333"

- name: Upload coverage to Codacy
if: ${{ env.CODACY_PROJECT_TOKEN != '' }}
Expand Down
10 changes: 10 additions & 0 deletions PanoramicData.EPPlus.Test/AddPictureFromBytesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,16 @@ public void AddPictureFromBytes_RoundTripsThroughASavedPackage()
saved = package.GetAsByteArray();
}

if (!OperatingSystem.IsWindowsVersionAtLeast(6, 1))
{
// Reading a picture back goes through ExcelPicture's loading constructor, which uses
// System.Drawing and deliberately throws where that is unsupported. Adding and saving
// (asserted above) work everywhere; assert the documented limit rather than skip.
using var unsupported = new ExcelPackage(new MemoryStream(saved));
Assert.ThrowsException<PlatformNotSupportedException>(() => unsupported.Workbook.Worksheets[0].Drawings);
return;
}

using var reopened = new ExcelPackage(new MemoryStream(saved));
var drawing = reopened.Workbook.Worksheets[0].Drawings["CatBytes"];
Assert.IsInstanceOfType(drawing, typeof(ExcelPicture));
Expand Down
2 changes: 0 additions & 2 deletions PanoramicData.EPPlus/PanoramicData.EPPlus.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
<TargetFramework>net10.0</TargetFramework>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageIcon>icon.jpg</PackageIcon>
<PackageLicenseUrl></PackageLicenseUrl>
<PackageProjectUrl>https://github.com/rimland/EPPlus</PackageProjectUrl>
<Authors>Rimland, Panoramic Data Limited</Authors>
<Company></Company>
Expand All @@ -26,7 +25,6 @@
<SignAssembly>False</SignAssembly>
<AssemblyOriginatorKeyFile>OpenOfficeXml.Rimland.snk</AssemblyOriginatorKeyFile>
<NeutralLanguage />
<PackageLicenseFile>lgpl-3.0.txt</PackageLicenseFile>
<!-- Vendored EPPlus source was never fully annotated: keep the annotations, drop the nullable warnings. -->
<Nullable>annotations</Nullable>
<!-- Same reason: about 2,200 vendored public members have no XML documentation. -->
Expand Down
Loading