Skip to content

fix: honor setting PATH remediations and register native MCP - #249

Merged
SebTardif merged 2 commits into
mainfrom
fix/improve-mpi-20260828-s0738
Aug 28, 2026
Merged

fix: honor setting PATH remediations and register native MCP#249
SebTardif merged 2 commits into
mainfrom
fix/improve-mpi-20260828-s0738

Conversation

@SebTardif

Copy link
Copy Markdown
Contributor

Summary

Two live-red product bugs from MPI cycle 6.

When patchloom.path points at a missing binary, the status bar still
offered Install/Reinstall. Managed install succeeded, resolution still
used the broken setting, and the user looped. Not-ready remediations
now follow the same source rule as upgrades: Settings for
patchloom.path, Releases for PATH, managed install only when that is
the winning source.

Native MCP registration used API names that never existed
(registerMCPServerDefinitionProvider). VS Code 1.100+ never saw a
provider. The extension now registers registerMcpServerDefinitionProvider
with McpStdioServerDefinition, declares
contributes.mcpServerDefinitionProviders, and fires
onDidChangeMcpServerDefinitions after install/settings/trust.

Verification

  • Unit tests for not-ready setting/PATH remediations
  • Descriptor + contribution-point tests for native MCP
  • npm run check

Checklist

  • All commits in this pull request are signed off with git commit -s
  • I ran npm run check and it passes
  • I updated docs if user-facing behavior changed
  • I am contributing this work under the repository license (MIT)

When the CLI is not ready, prefer Open Settings for patchloom.path and Open Releases for PATH. Install and Reinstall only apply when those sources are not active, because a broken setting still wins resolution.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Use registerMcpServerDefinitionProvider, fire onDidChangeMcpServerDefinitions after refresh, and contribute mcpServerDefinitionProviders. Keep a plain {label, command, args} descriptor for unit tests.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
@SebTardif
SebTardif marked this pull request as ready for review August 28, 2026 14:44
@SebTardif
SebTardif enabled auto-merge (squash) August 28, 2026 14:44
@SebTardif
SebTardif merged commit 62c0e5f into main Aug 28, 2026
22 checks passed
@SebTardif
SebTardif deleted the fix/improve-mpi-20260828-s0738 branch August 28, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant