fix: honor setting PATH remediations and register native MCP - #249
Merged
Conversation
When the CLI is not ready, prefer Open Settings for patchloom.path and Open Releases for PATH. Install and Reinstall only apply when those sources are not active, because a broken setting still wins resolution. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Use registerMcpServerDefinitionProvider, fire onDidChangeMcpServerDefinitions after refresh, and contribute mcpServerDefinitionProviders. Keep a plain {label, command, args} descriptor for unit tests.
Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
marked this pull request as ready for review
August 28, 2026 14:44
SebTardif
enabled auto-merge (squash)
August 28, 2026 14:44
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two live-red product bugs from MPI cycle 6.
When
patchloom.pathpoints at a missing binary, the status bar stilloffered Install/Reinstall. Managed install succeeded, resolution still
used the broken setting, and the user looped. Not-ready remediations
now follow the same source rule as upgrades: Settings for
patchloom.path, Releases for PATH, managed install only when that isthe winning source.
Native MCP registration used API names that never existed
(
registerMCPServerDefinitionProvider). VS Code 1.100+ never saw aprovider. The extension now registers
registerMcpServerDefinitionProviderwith
McpStdioServerDefinition, declarescontributes.mcpServerDefinitionProviders, and firesonDidChangeMcpServerDefinitionsafter install/settings/trust.Verification
npm run checkChecklist
git commit -snpm run checkand it passes