Extract shared release workflows - #1819
Merged
benalleng merged 4 commits intoAug 18, 2026
Merged
Conversation
Every registry publish job must refuse to push an artifact whose version differs from what the pushed tag calls for. The check was written inline in the NuGet publish job; the upcoming npm, pub.dev, and PyPI publish jobs would each duplicate it. Move the prefix-strip-and-compare into a verify-tag-version composite action taking the tag prefix and the actual packed version. The NuGet job keeps its locate step (exactly one .nupkg, version parsed from the filename) and hands the result to the action. Local actions resolve from the workspace, so the job gains a checkout step it previously avoided; its contents: read permission already covers it.
The annotated, trusted-signature, and ancestor-of-master checks in verify-tag.sh apply to any release tag, not only crate release tags. Move them into verify-tag-hygiene.sh so tag-triggered publishing workflows for language bindings can enforce the same authenticity gate without taking on the crate-specific checks (manifest version, release invariants, sibling crates.io dependencies), which stay in verify-tag.sh. Pure code move; verify-tag.sh behavior is unchanged.
This was referenced Aug 18, 2026
Merged
Merged
Collaborator
Coverage Report for CI Build 32180561470Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 86.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
force-pushed
the
extract-shared-release-workflows
branch
from
August 18, 2026 19:58
d6e3b20 to
c6024f6
Compare
Publishing ends the same way for every binding: download the packed artifact, generate SHA256SUMS, and attach both to the GitHub release for the pushed tag. Move the job to release-assets.yml as a workflow_call and point the C# github-release job at it. The artifact-pattern input downloads and merges multiple artifacts for workflows that build one per platform. Two behavior notes: the job now runs on ubuntu-26.04 like the rest of the repo instead of ubuntu-latest, and pre-release detection derives from a SemVer hyphen in the tag's version (ignoring + build metadata) instead of matching only -preview and -rc, which classifies all existing tags identically.
spacebear21
force-pushed
the
extract-shared-release-workflows
branch
from
August 18, 2026 20:08
c6024f6 to
ea9d982
Compare
spacebear21
marked this pull request as ready for review
August 18, 2026 20:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparatory PR extracting shared logic between release workflows.
Three follow-up PRs build on top of this:
Co-authored with Claude Fable 5
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.