Dart release workflow - #1820
Conversation
Coverage Report for CI Build 32275318846Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 86.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
33eb6dc to
2e513dc
Compare
580fa43 to
8afbb4c
Compare
The script hardcoded --features dart,_test-utils --profile dev, so every published release shipped bindings declaring test-only APIs whose symbols are absent from consumer builds, a limitation CONTRIBUTING.md called out. Adopt the PAYJOIN_FFI_FEATURES / PAYJOIN_FFI_PROFILE convention the C# generate_bindings.sh already uses: defaults are unchanged for tests, and a release build sets PAYJOIN_FFI_FEATURES= (empty) to emit bindings with no test-only declarations.
Add the tag-gated publishing path to the Dart workflow, following the NuGet flow in csharp.yml adapted to a source-only registry:pub.dev ships Dart source plus the native/ wrapper crate andconsumers compile the Rust through hook/build.dart, so there is no artifact to pack, smoke test, or attach to a GitHub release.
8afbb4c to
8a76d46
Compare
There was a problem hiding this comment.
ACK 8a76d46
In the publish-pub job does it need to be tagged by someone / something that has access to this or is this already covered by the "payjoin.org" owner listed on the site?
Does
id-token: write # OIDC: pub.dev automated publishing
persist in our nix-shell?
pub.dev never checks who created the tag, only a valid OIDC token from Github Actions. On the github side we have the same release environment workflow as we use for crates releases, so it needs a signed tag from one of the three maintainers + a workflow approval from another.
Yes my understanding is it would only be a problem if we ran nix with |
3 participants
Builds on top of #1819
Add trusted publishing release workflow for Dart bindings.
Co-authored by Claude Fable 5
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.