MILAB-6950: update SDK - #47
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| better-sqlite3@13.0.3: | ||
| resolution: {integrity: sha512-RbOBxmLBG8uvFUc15X9+9SFemKcQ0WBuISBVkpuiaUB2qblC8UWlHEjdWVoZ8AdhSwmoEgsiXKfopX0CQxaACQ==} | ||
| engines: {node: '>=22'} |
There was a problem hiding this comment.
CI runs Node 20.x, but the updated test dependency graph resolves better-sqlite3@13.0.3, which requires Node 22 or newer. The previous version supported Node 20. This leaves the configured CI test stack on an unsupported runtime, where the native dependency may fail to install or load. Align the CI runtime with the new dependency before relying on the build and test results.
Knowledge Base Used: Validation and release automation
Prompt To Fix With AI
This is a comment left during a code review.
Path: pnpm-lock.yaml
Line: 2808-2810
Comment:
**Native dependency requires newer Node**
CI runs Node 20.x, but the updated test dependency graph resolves `better-sqlite3@13.0.3`, which requires Node 22 or newer. The previous version supported Node 20. This leaves the configured CI test stack on an unsupported runtime, where the native dependency may fail to install or load. Align the CI runtime with the new dependency before relying on the build and test results.
**Knowledge Base Used:** [Validation and release automation](https://app.greptile.com/milaboratories/-/custom-context/knowledge-base/platforma-open/clonotype-browser/-/docs/validation-and-release-automation.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
There was a problem hiding this comment.
Fixed in c92cbc2: CI (build and mark-stable workflows) now runs on Node 22.x, matching the other blocks.
| "@platforma-sdk/block-tools": 2.14.3 | ||
| "@platforma-sdk/workflow-tengo": 6.12.1 | ||
| "@platforma-sdk/model": 1.84.1 | ||
| "@platforma-sdk/ui-vue": 1.84.2 |
There was a problem hiding this comment.
This SDK update is meant to stop saved table state from repeatedly rebuilding the grid, but it adds no test for restoring that state. All three UI tables persist grid state, while the workspace’s only workflow scenario is disabled and the test command accepts zero tests. A later SDK update could bring back the loop without failing a check; a saved-state regression test would guard against that.
Knowledge Base Used: Workflow validation tests
Prompt To Fix With AI
This is a comment left during a code review.
Path: pnpm-workspace.yaml
Line: 16
Comment:
**Grid fix lacks regression coverage**
This SDK update is meant to stop saved table state from repeatedly rebuilding the grid, but it adds no test for restoring that state. All three UI tables persist grid state, while the workspace’s only workflow scenario is disabled and the test command accepts zero tests. A later SDK update could bring back the loop without failing a check; a saved-state regression test would guard against that.
**Knowledge Base Used:** [Workflow validation tests](https://app.greptile.com/milaboratories/-/custom-context/knowledge-base/platforma-open/clonotype-browser/-/docs/workflow-validation-tests.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
The fix and its regression coverage live in the SDK, not in this block. @platforma-sdk/ui-vue tests the stored-state comparison in sdk/ui-vue/src/components/PlAgDataTable/sources/grid-state.test.ts and mounts PlAgDataTableV2 through a reload in sdk/ui-vue/src/components/PlAgDataTable/__tests__/PlAgDataTableV2.reload.jsdomtest.ts. This PR only bumps the dependency; a block-level test would duplicate that coverage and needs a mounted AG Grid, which the block test setup does not provide. Not adding one here.
There was a problem hiding this comment.
That’s a fair clarification. Because the saved-state comparison and PlAgDataTableV2 reload behavior are already covered in @platforma-sdk/ui-vue by grid-state.test.ts and PlAgDataTableV2.reload.jsdomtest.ts, a block-level test would duplicate upstream coverage and would not be practical without the SDK’s mounted AG Grid test setup. I’m withdrawing the “Grid fix lacks regression coverage” finding; no additional test is needed for this PR.
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
1 participant
Bumps the SDK catalog to the current npm latest (
pnpm update-sdk), mainly to pick up@platforma-sdk/ui-vue1.84.2.That release fixes
PlAgDataTableV2rebuilding its AG Grid endlessly (~20 times a second) when the page has a saved grid state — most often right after a block rebuild. The loop strobed the column headers and flooded the console with AG Grid licence banners. The reload comparison now filters the stored state down to the columns the grid actually has and compares only the fields that state expresses, so it converges.Changes:
pnpm-workspace.yaml: SDK catalog entries → npm latestpnpm-lock.yaml: regeneratedVerified locally:
pnpm install+pnpm build:dev-no-softwarepass.The PR should align CI’s Node runtime with the newly resolved native dependency before merging.
Fix with agent prompt
Summary
The PR refreshes the workspace SDK catalog and lockfile and adds a patch changeset for the saved-grid-state fix. Important touched terms:
PlAgDataTableV2/ saved grid state — the UI table and its persisted configuration; theui-vuebump is intended to stop repeated grid reconstruction after state restoration.@platforma-sdk/modelmoves to 1.84.1.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR C[Workspace SDK catalog] --> L[pnpm lockfile] L --> U[ui-vue 1.84.2] U --> G[Saved-state grid tables] L --> T[Test SDK and middle layer] T --> N[better-sqlite3 13] CI[CI: Node 20.x] --> T N --> E[Requires Node 22+]Reviews (1) · Last reviewed commit: "MILAB-6950: update SDK"