MILAB-6950: update SDK - #14
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "@platforma-sdk/tengo-builder": 4.1.1 | ||
| "@platforma-sdk/workflow-tengo": 6.12.1 | ||
| "@platforma-sdk/model": 1.84.1 | ||
| "@platforma-sdk/ui-vue": 1.84.2 |
There was a problem hiding this comment.
PlAgDataTableV2 from repeatedly rebuilding when a project has saved grid state, but this PR adds no regression test for that behavior. The block binds the table to persisted tableState, while the test package permits zero tests. CI can therefore pass without checking that the grid settles after a block rebuild. Please add a test that loads saved state and checks that transition.
Prompt To Fix With AI
This is a comment left during a code review.
Path: pnpm-workspace.yaml
Line: 16
Comment:
**Saved grid state untested** The UI SDK update is intended to stop `PlAgDataTableV2` from repeatedly rebuilding when a project has saved grid state, but this PR adds no regression test for that behavior. The block binds the table to persisted `tableState`, while the test package permits zero tests. CI can therefore pass without checking that the grid settles after a block rebuild. Please add a test that loads saved state and checks that transition.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
The fix and its regression coverage live in the SDK, not in this block. @platforma-sdk/ui-vue tests the stored-state comparison in sdk/ui-vue/src/components/PlAgDataTable/sources/grid-state.test.ts and mounts PlAgDataTableV2 through a reload in sdk/ui-vue/src/components/PlAgDataTable/__tests__/PlAgDataTableV2.reload.jsdomtest.ts. This PR only bumps the dependency; a block-level test would duplicate that coverage and needs a mounted AG Grid, which the block test setup does not provide. Not adding one here.
There was a problem hiding this comment.
That’s a valid distinction. Since the behavior change and its regression tests live in @platforma-sdk/ui-vue, and this PR only updates the SDK catalog/lockfile, a block-level test would duplicate the SDK coverage rather than test code changed here. The block test setup also cannot mount the AG Grid needed to exercise this path. I’m withdrawing the “Saved Grid State Untested” finding; no additional test is required in this PR.
Tip: You can customize Greptile's behavior for this repo with .greptile/rules.md and .greptile/config.json.
1 participant
Bumps the SDK catalog to the current npm latest (
pnpm update-sdk), mainly to pick up@platforma-sdk/ui-vue1.84.2.That release fixes
PlAgDataTableV2rebuilding its AG Grid endlessly (~20 times a second) when the page has a saved grid state — most often right after a block rebuild. The loop strobed the column headers and flooded the console with AG Grid licence banners. The reload comparison now filters the stored state down to the columns the grid actually has and compares only the fields that state expresses, so it converges.Changes:
pnpm-workspace.yaml: SDK catalog entries → npm latestpnpm-lock.yaml: regeneratedVerified locally:
pnpm install+pnpm build:dev-no-softwarepass.The PR appears safe to merge, with a non-blocking gap in regression coverage for saved grid state.
Fix with agent prompt
Summary
The PR updates six Platforma SDK catalog entries, regenerates their lockfile resolutions, and adds a patch changeset for the block.
PlAgDataTableV2grid creation with saved state.PlDataTableStateV2is the persisted table-state type; its model SDK dependency moves to 1.84.1, with no block-side schema change.BlockDatais the block’s persisted data type containingtableState; its definition is unchanged.PColumnIdAndSpecidentifies a table column and its specification; its definition and use are unchanged, while the UI SDK that renders columns moves to 1.84.2.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Catalog["pnpm SDK catalog"] --> Lock["pnpm-lock.yaml"] Lock --> Model["@platforma-sdk/model 1.84.1"] Lock --> UI["@platforma-sdk/ui-vue 1.84.2"] Model --> State["Persisted PlDataTableStateV2"] State --> Grid["PlAgDataTableV2"] UI --> GridReviews (1) · Last reviewed commit: "MILAB-6950: update SDK"