Harden design skill routing and token contracts

[mosobande]

Why

The design-skill system had overlapping outcome ownership, duplicated dependency procedures, stale helper claims, and token contracts that did not match slide generation. This stacked child keeps each specialist independently useful while separating lightweight design routing from artifact production and preserving PR #22's non-design contracts.

Stack

• Parent: PR Harden skill contracts and portfolio integrity #22, feature/lightweight-skill-contracts, exact base 688810c1dfa8cb40b9af647a493d667edf7e3522.
• Child: this PR, fix/design-skill-system-cleanup, exact head e3aa5203d6f589cfa0929ddd84d04a5e258ac59a.
• Both branches remain one-commit stacked candidates and the audit-plan artifact is absent from their reachable history.
• Merge PR Harden skill contracts and portfolio integrity #22 to ori first. Then retarget this PR to ori and reverify the unchanged design candidate.

What changed

Lightweight design routing

• Make apere a lightweight design router for broad, ambiguous, or multi-deliverable visual work.
• Route focused requests directly to their specialist.
• Hand integrated multi-artifact production to alaga after routing.

Design ownership

• Move logo exploration, corporate-identity resources, custom-icon visual language, and bundled search resources from apere to brand.
• Keep product/UI icon implementation with asa-oju-ibanisoro.
• Add social-graphics as a lightweight public skill for feed posts, carousels, stories, templates, and campaign variants.
• Keep banner-design focused on banner-like display surfaces.
• Keep amoye-ui-ux as owner of evidence-backed visual/UX direction and optional persisted MASTER/page records.
• Keep eto-apere as owner of canonical design tokens, component specifications, generated configuration, validation, and token migrations.

Existing design hardening retained

• Preserve token-alias, token-validation, slide-contract, Tailwind, shadcn, and Brand token-writer cleanup.
• Preserve shell-free Brand color extraction and regression coverage.
• Keep slide-production internals with slides.
• Reconcile Alarina, README, plugin catalog, and the design changeset without removing parent routes.

Release ownership inherited from parent

The child inherits PR #22's simplified release model: Changesets owns package versioning, npm regenerates package-lock.json, README uses the stable latest-release link, and there are no custom release/catalog synchronizer scripts or duplicate VERSION file.

Verification

The design implementation is unchanged from the previously accepted design candidate apart from inheriting the parent's release-tool simplification and stable README release link. The prior design validation passed Python compilation, JavaScript syntax, 39/39 Amoye tests, 7/7 Slides tests, and the Brand pytest suite.

Àtúnwò review remains RECOMMEND_ACCEPT for the design ownership and routing candidate; the release simplification is owned and reviewed in the parent.

Review focus

1. apere as a lightweight router rather than an end-to-end producer;
2. identity-resource ownership under brand and UI-icon implementation under asa-oju-ibanisoro;
3. social-graphics versus banner-design;
4. Amoye persisted visual direction versus Eto Apere implementation-token ownership;
5. preservation of existing token and slide hardening while inheriting the parent release model.

Contributor: @mosobande

[atunwo]

🤖 Alátùńwò AI review failed — I couldn't complete this review.

Please re-request a review to try again.

Error detail

{"type":"error","status":400,"error":{"type":"invalid_request_error","message":"The 'gpt-5.6-sol' model requires a newer version of Codex. Please upgrade to the latest app or CLI and try again."}}

[atunwo]

🤖 Alátùńwò AI review failed — I couldn't complete this review.

Please re-request a review to try again.

Error detail

The operation was aborted

[atunwo]

🤖 Alátùńwò AI review failed — I couldn't complete this review.

Please re-request a review to try again.

Error detail

The operation was aborted

[atunwo]

🤖 Alátùńwò AI review · 📄 Diff-only

Reviewed from the pull request diff only (no surrounding files).

This PR clarifies design-skill ownership and hardens token/slide validation.

• No blocking issues found.
• The slide-token reference contains one canonical-name mismatch that would produce an undefined CSS variable if copied.

[atunwo]

WARN — --spacing-section is not a canonical generated variable: the new architecture maps primitive.spacing.* to --space-*. Copying this slide contract will leave --slide-padding aliased to an undefined property. Change this to --slide-padding: var(--space-section); (assuming semantic.spacing.section resolves to that primitive).