feat(opencode): V2 permission.requested alongside V1 publish - #78
Merged
Conversation
Adds `SessionEvent.Permission.Requested` (live event, type `session.next.permission.requested`) carrying the full `PermissionV1.Request` payload and fires it alongside the existing V1 `events.publish(Event.Asked, info)` in the permission service. This is the V2 surface for the legacy V1 `permission.ask` hook (which fires via `HookV2` watching `permission.asked`). Plugins subscribe via `events.subscribe`/`events.subscribeAll` to attach audit/telemetry without registering a V1 plugin. The V1 hook continues to fire so existing plugins keep working.
This was referenced Aug 21, 2026
filipeforattini
added a commit
that referenced
this pull request
Aug 21, 2026
Adds `SessionEvent.Text.Complete` (live waterfall event, type `session.next.text.complete`) carrying `{ sessionID, messageID, partID, text }` and wires `EventV2Bridge.waterfall` into the text-complete dispatch next to the existing V1 `plugin.trigger('experimental.text.complete', ...)`.
The waterfall currently has a single listener that delegates to the V1 trigger so existing plugins keep working. Listeners return `{ text }` to transform the final text; throwing short-circuits the text part. Same shim pattern as #70 #72 #75 #76 #77 #78 #79.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth V1→V2 shim in the series (#70 #72 #75 #76 #77). Adds
SessionEvent.Permission.Requested(live event, typesession.next.permission.requested) carrying the fullPermissionV1.Requestpayload and fires it alongside the existing V1events.publish(Event.Asked, info)in the permission service.What this PR does
Permission.Requestedcarrying the full request shape (id, sessionID, permission, patterns, metadata, always, tool).permission.asked) and V2 (session.next.permission.requested) on each ask, so V2 plugins can subscribe without registering a V1 plugin.permission.askhook continues to fire (viaHookV2watching the V1 event) so existing plugins keep working.Pattern
Same as the rest: V2 events alongside V1 hooks, plugins pick whichever surface fits them. For
permission.requestedthe dispatch isemit(parallel) — no veto because the ask already happened, observation only.Out of scope
experimental.session.compacting/experimental.compaction.autocontinue/experimental.text.complete(all emit)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.