fix(ios): point flavor xcconfigs at existing entrypoints - #120
Merged
Merged
Conversation
- Release.xcconfig: FLUTTER_TARGET referenced lib/main/env/main.dart, which does not exist; the prod entrypoint is lib/main.dart. - qa.xcconfig: the QA flavor ran main_dev.dart (and PREFIX=dev); use main_qa.dart / PREFIX=qa. - README: build commands used the same missing path, a nonexistent env_prod.json, and `appBundle` (the subcommand is `appbundle`). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
tarruk
approved these changes
Sep 22, 2026
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Environment selection, production build configuration, and dotenv handling remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (4)
What changed in this PR
Updates iOS flavor configurations and production build documentation to use existing Dart entrypoints.
Changes:
- Points Release and QA xcconfigs to valid entrypoints.
- Updates QA flavor metadata.
- Revises production build commands and environment guidance.
| File | Description |
|---|---|
README.md |
Updates production build documentation and environment setup. |
app/ios/qa.xcconfig |
Uses the QA Dart entrypoint and prefix. |
app/ios/Flutter/Release.xcconfig |
Uses the production Dart entrypoint. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+4
to
5
| FLUTTER_TARGET=lib/main.dart | ||
| FLUTTER_BUILD_NAME=2.0.0 |
|
|
||
| The production entry point is `lib/main.dart`. Run the commands from `app/`. The env file passed to | ||
| `--dart-define-from-file` must define `ENV=prod`, because `init.dart` then loads `env/.prod` as the dotenv file. | ||
| Create `app/env/.prod` first (following `app/env/.dev`) and don't commit real secrets. |
| #include "Generated.xcconfig" | ||
|
|
||
| FLUTTER_TARGET=lib/main/env/main_dev.dart | ||
| FLUTTER_TARGET=lib/main/env/main_qa.dart |
|
|
||
| ```text | ||
| flutter build appBundle -t lib/main/env/main.dart --dart-define-from-file=env_prod.json | ||
| flutter build appbundle -t lib/main.dart --dart-define-from-file=env/.prod |
amaury901130
added a commit
that referenced
this pull request
Sep 22, 2026
- known-issues: mark #1 and #5 resolved, narrow #2 to the remaining env layout drift, update #3/#13 for the new common and domain tests - overview, CLAUDE.md, feature guide: drop the mapError warning, describe the API_URL fallback - testing, bootstrap customization: current test dirs and sonar.tests Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The iOS flavor configs and the README build instructions reference entrypoints that don't exist or are the wrong ones:
app/ios/Flutter/Release.xcconfigFLUTTER_TARGET=lib/main/env/main.dart(doesn't exist)lib/main.dart(the prod entrypoint)app/ios/qa.xcconfigFLUTTER_TARGET=lib/main/env/main_dev.dart,PREFIX=devlib/main/env/main_qa.dart,PREFIX=qaREADME.md§ Build Production Appflutter build appBundle -t lib/main/env/main.dart --dart-define-from-file=env_prod.jsonflutter build appbundle -t lib/main.dart --dart-define-from-file=env/.prod, plus a note that the file must setENV=prod(that's howinit.dartpicks the dotenv file)PREFIXisn't read anywhere in the iOS or Android projects, so that change only keeps the QA file consistent.Issue
known-issues #5 in #117.
Preview
N/A
Notes:
cd app && flutter build ios --flavor qa --no-codesignand an Archive of theRunnerscheme (Release).FLUTTER_TARGETafter#include "Generated.xcconfig", so they override the target thatflutter build -twrites there. That behaviour is unchanged by this PR, but reviewers may want to decide whether the xcconfigs should setFLUTTER_TARGETat all.env/.prodisn't added: its API URL is project-specific.🤖 Generated with Claude Code