build(W-23983692): upgrade to typescript v6 and eslint v10 - #2918
Merged
Conversation
|
This PR lacks any commits of the 'fix' or 'feat' type, and therefore will not trigger a release. To silence all further warnings, react to this warning comment (or any other) with the 👀 emoji. NOTE: If your repo uses squash commits, make sure to add the appropriate conventional commit prefix (e.g., 'fix:', 'feat:', 'chore:', etc) in the squash commit message. |
Closed
2 tasks
jfeingold35
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates the CLI's dev toolchain to TypeScript v6 and eslint v10:
.eslintrc.cjsfiles with an ESLint 10 flat config (eslint.config.mjs), removing.eslintignore, root.eslintrc.cjs, andtest/.eslintrc.cjs.@salesforce/dev-scriptsto v14,eslintto v10,typescriptto v6, and@salesforce/ts-typesto ^3.2.0.@types/*devDeps (chai,mocha,node,sinon) andmochatypes intsconfig.json/test/tsconfig.jsonnow required by the toolchain, plus arootDirand the**/eslint.config.*glob to the wireit lint inputs.The only source change is in
src/flags.ts, applying the??=idiom now enforced by the updated lint config.Acceptance Criteria
yarn build,yarn lint, andyarn testpass under TypeScript 6, ESLint 10 flat config, and dev-scripts 14.Testing Notes
Covered by the existing automated build/lint/test suite. Verify locally with a clean install:
yarn installyarn buildyarn lint— confirm the flat config is picked up and there are no errors.yarn testNo manual CLI testing applicable — there are no command, flag, or output changes.
Checklist
What issues does this PR fix or reference?
@W-23983692@