Skip to content

build(W-23983692): upgrade to typescript v6 and eslint v10 - #2918

Merged
jfeingold35 merged 1 commit into
mainfrom
k80/ts-v6-2
Sep 10, 2026
Merged

build(W-23983692): upgrade to typescript v6 and eslint v10#2918
jfeingold35 merged 1 commit into
mainfrom
k80/ts-v6-2

Conversation

@k80bowman

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates the CLI's dev toolchain to TypeScript v6 and eslint v10:

  1. Replaces the legacy .eslintrc.cjs files with an ESLint 10 flat config (eslint.config.mjs), removing .eslintignore, root .eslintrc.cjs, and test/.eslintrc.cjs.
  2. Bumps @salesforce/dev-scripts to v14, eslint to v10, typescript to v6, and @salesforce/ts-types to ^3.2.0.
  3. Adds explicit @types/* devDeps (chai, mocha, node, sinon) and mocha types in tsconfig.json/test/tsconfig.json now required by the toolchain, plus a rootDir and the **/eslint.config.* glob to the wireit lint inputs.

The only source change is in src/flags.ts, applying the ??= idiom now enforced by the updated lint config.

Acceptance Criteria

  • yarn build, yarn lint, and yarn test pass under TypeScript 6, ESLint 10 flat config, and dev-scripts 14.

Testing Notes

Covered by the existing automated build/lint/test suite. Verify locally with a clean install:

  1. yarn install
  2. yarn build
  3. yarn lint — confirm the flat config is picked up and there are no errors.
  4. yarn test

No manual CLI testing applicable — there are no command, flag, or output changes.

Checklist

  • This change has been approved by the CLI Review Board or approval isn't required. Anything that adds/changes/deletes commands, flags, output, or json output has to be reviewed.
  • Does this follow the deprecation policy?

What issues does this PR fix or reference?

@W-23983692@

@github-actions

Copy link
Copy Markdown

This PR lacks any commits of the 'fix' or 'feat' type, and therefore will not trigger a release. To silence all further warnings, react to this warning comment (or any other) with the 👀 emoji.

NOTE: If your repo uses squash commits, make sure to add the appropriate conventional commit prefix (e.g., 'fix:', 'feat:', 'chore:', etc) in the squash commit message.

@jfeingold35
jfeingold35 merged commit bd99e66 into main Sep 10, 2026
37 checks passed
@jfeingold35
jfeingold35 deleted the k80/ts-v6-2 branch September 10, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants