Skip to content

feat(javascript): add Node.js crypto library algorithms - #4

Merged
jrepucci-rh merged 8 commits into
mainfrom
nodejs_algo
Sep 23, 2026
Merged

jrepucci-rh merged 8 commits into
mainfrom
nodejs_algo

Conversation

@jrepucci-rh

@jrepucci-rh jrepucci-rh commented Sep 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Adds rules for detecting algorithms from the Node.js crypto library.

AI Generated by: Claude (using Opus 5)

Type of change

  • New rule(s)
  • New / updated test fixtures
  • Bug fix (false positive / false negative)
  • Test framework or tooling
  • Documentation

Checklist

  • New / changed rules have matching test fixtures
  • make test passes locally
  • Rule files validate with opengrep --validate
  • Commits follow Conventional Commits
  • No private or internal data is included in this change

Notes for reviewers

Open to removing the rules that flag the "padding" parameter.

Likely will need to change the header comments in front of every file, or even remove them. I gave them a look-over and nothing seemed egregiously wrong but I likely missed something. Consider them now as more notes left by the AI author for the reviewer.

@jrepucci-rh
jrepucci-rh marked this pull request as ready for review September 18, 2026 14:59
@jrepucci-rh jrepucci-rh changed the title Node.js crypto library algorithms feat(javascript): Added Node.js crypto library algorithms Sep 18, 2026
@jrepucci-rh jrepucci-rh changed the title feat(javascript): Added Node.js crypto library algorithms feat(javascript): add Node.js crypto library algorithms Sep 18, 2026
@jrepucci-rh
jrepucci-rh merged commit c5f32b7 into main Sep 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant