Repository navigation
native: annotate module-level values; discarded matches run in place - #166
Merged
Merged
Conversation
mypyc's front end rejected two shapes a real multi-module program produces:
- A module-level value another module reads ("Cannot determine type").
Native mode now writes the type down: `_X: X = X()` for a nullary
singleton, and the inferred type on the first assignment of a
top-level value bound once, when Python can spell it.
- A unit match in statement position, hoisted into a temp that is only
ever assigned unit calls ("has inferred type None"). The arms now
evaluate in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypyc's front end rejected two shapes that a real multi-module program produces. This fixes both.
_X: X = X()for a nullary singleton;With both fixes, a real multi-module program gets through mypyc's type checking locally. It stops only at
build_exton a machine without a C compiler.Tests:
native_annotates_module_level_values_for_other_modulesandnative_evaluates_a_discarded_match_in_place. ROADMAP and INTERNALS are updated.