fix(ci): untrack the build-materialized lvgl usr files - #313
Merged
Conversation
The tree-wide e-mail alignment (#309) ran over a working tree that carried the lvgl build outputs and committed 37 of them: lib/lv_conf.h, the lib/slv/ sources, the quilt staging directory usr/patches/ and the materialized src/{fillfb,lvgl_*}.c. All of these are created by the lvgl patch set at build time, so on a fresh clone do_patch now finds its own outputs already present and dies on the very first patch ('would create lib/lv_conf.h, which already exists') — the Build workflow has been red since that merge, on every branch. Remove them and gitignore the whole family so they cannot be committed again. Note the v6.2.4 tag carries the broken state: a fresh clone of the tag needs these paths cleaned before usr-so3 builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree-wide e-mail alignment (#309) ran over a working tree that carried the lvgl build outputs and committed 37 of them:
lib/lv_conf.h, thelib/slv/sources, the quilt staging directoryusr/patches/and the materializedsrc/{fillfb,lvgl_*}.c. All of these are created by the lvgl patch set at build time, so on a fresh clonedo_patchfinds its own outputs already present and dies on the very first patch (would create lib/lv_conf.h, which already exists) — the Build workflow has been red since that merge (#309's own PR run already showed it), on every branch including v6.2.4.git rmof the 37 files added by 02a56e0 (exactly the--diff-filter=Aset of that commit).gitignore: the whole family is now ignored (usr/patches/,lib/slv/,lib/lv_conf.h, the materializedsrc/sources) so it cannot come backNote: the v6.2.4 tag carries the broken state — a fresh clone of the tag needs these paths cleaned before
usr-so3builds.CI on this PR is the validation: the Build workflow should go green again.