Repository navigation
ctrl+l restores terminal modes; drop the focus redraw - #300
Merged
Merged
Conversation
ctrl+l now re-enters the alternate screen and sends mouse, paste and keyboard modes again before the full redraw, so a host terminal that dropped them (T3 Code's hidden panel) gets a clickable board back. Focus reporting and its redraw on focus in are removed: they did not help in T3 Code and redrew the whole board on every pane switch.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a terminal hides a pane and then rebuilds it, the board can come back as scattered text that ignores clicks. T3 Code's panel does this: it replays a trimmed output log, which loses the screen and the input modes tsk set at startup.
ctrl+lalready redrew the screen, but the mouse stayed off. This PR makesctrl+lthe one recovery key and drops the parts that only existed for T3 Code. It replaces #299.What changed
ctrl+lenters the alternate screen again, sends mouse, paste and keyboard modes again, then redraws every cell. The keyboard flags are popped before the push, so the flag stack doesn't grow.Scope
ctrl+ldoes, and taking out focus reporting.Done when
ctrl+lsends every mode again and redraws in full, without asking for the cursor positionctrl+lbrings a reopened board back whole and clickablectrl+l, click a rowVerification
Commit: 42d8491
cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test, pluscargo clippy --all-targets --target x86_64-pc-windows-gnu -- -D warningsinput.restore()commented out by hand,ctrl_l_restores_the_modes_and_a_screen_the_host_terminal_droppedfails.TSK_STATE_DIR,TSK_CONFIG_DIRandHOMEin a temporary folder).Could break
Every terminal gets one change: tsk no longer asks for focus reports, so no terminal sends them.
ctrl+lwas already reserved on every screen by #297.Review
The Pi review panel ran on 42d8491 with 8 seats (holistic, tests, spec conformance and correctness, each on sol and opus). It returned one finding.
ctrl+lthrough the real event loop and shows the full redraw, so the wiring is covered.