add_info_from_network: do not swallow exceptions - #10980
Merged
SomberNight merged 1 commit intoSep 18, 2026
Merged
Conversation
ecdsa
force-pushed
the
add_input_from_network_do_not_ignore_exceptions
branch
from
September 18, 2026 14:46
7aa6045 to
118b8e7
Compare
An attacker can provide a witness_utxo whose value disagrees with the real previous transaction. That would raise PSBTInputConsistencyFailure, which is swallowed because it is not a NetworkException. This would lead us to sign a tx with the wrong input amount. (no fund loss: the tx is invalid under BIP143)
ecdsa
force-pushed
the
add_input_from_network_do_not_ignore_exceptions
branch
from
September 18, 2026 14:59
118b8e7 to
3f67b21
Compare
ecdsa
marked this pull request as ready for review
September 18, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attacker can provide a witness_utxo whose value disagrees with the real previous transaction. That would raise PSBTInputConsistencyFailure, which is swallowed because it is not a NetworkException.
This would lead us to sign a tx with the wrong input amount. (no fund loss: the tx is invalid under BIP143)