Skip to content

add_info_from_network: do not swallow exceptions #10980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SomberNight merged 1 commit into from
Sep 18, 2026
+1 −1
Merged

add_info_from_network: do not swallow exceptions #10980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion electrum/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1302,7 +1302,7 @@ async def add_info_to_txin(txin: TxInput):
except Exception as e:
has_errored = True
_logger.error(f"tx.add_info_from_network() got exc: {e!r}")
if isinstance(e, NetworkException) and not ignore_network_issues:
if not (isinstance(e, NetworkException) and ignore_network_issues):
raise
finally:
has_finished = True
Expand Down