chore: fix and simplify the platform tests - #17171
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/4a9eb01686f330bb452f0862ee3cd440de1948adOpen in |
|
Nic-Polumeyv
marked this pull request as draft
September 21, 2026 03:03
Nic-Polumeyv
deployed
to
@sveltejs/adapter-node platform tests
September 21, 2026 03:26 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-node platform tests
September 21, 2026 03:26 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:26 — with
GitHub Actions
Active
Nic-Polumeyv
had a problem deploying
to
@sveltejs/adapter-vercel platform tests
September 21, 2026 03:27 — with
GitHub Actions
Failure
Nic-Polumeyv
had a problem deploying
to
@sveltejs/adapter-vercel platform tests
September 21, 2026 03:27 — with
GitHub Actions
Failure
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:27 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:27 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:27 — with
GitHub Actions
Active
… job the build output
Nic-Polumeyv
deployed
to
@sveltejs/adapter-node platform tests
September 21, 2026 03:36 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-node platform tests
September 21, 2026 03:36 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-vercel platform tests
September 21, 2026 03:37 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:37 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:37 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:37 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-netlify platform tests
September 21, 2026 03:37 — with
GitHub Actions
Active
Nic-Polumeyv
deployed
to
@sveltejs/adapter-vercel platform tests
September 21, 2026 03:37 — with
GitHub Actions
Active
Nic-Polumeyv
force-pushed
the
restore-platform-test-secrets
branch
2 times, most recently
from
September 21, 2026 04:09
7851eb7 to
9862a39
Compare
Nic-Polumeyv
marked this pull request as ready for review
September 21, 2026 04:12
Nic-Polumeyv
force-pushed
the
restore-platform-test-secrets
branch
from
September 21, 2026 05:05
5fe325b to
4a9eb01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17143. Environment secrets only resolve in a called workflow when the caller passes
secrets, so the deploy jobs get empty tokens, andpnpm/setuprejects the pnpm 10 that PRs based onmainuse.This passes
secrets: inherit, reads the pnpm version from the commit under test, and replaces the five per-platform workflows and four actions with one reusable workflow called per variant. The Vercel deploy now creates the project's root directory before deploying, and the test job gets the build output that the Netlify edge test reads.