Skip to content

chore: fix and simplify the platform tests - #17171

Merged
teemingc merged 4 commits into
mainfrom
restore-platform-test-secrets
Sep 21, 2026
Merged

teemingc merged 4 commits into
mainfrom
restore-platform-test-secrets

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #17143. Environment secrets only resolve in a called workflow when the caller passes secrets, so the deploy jobs get empty tokens, and pnpm/setup rejects the pnpm 10 that PRs based on main use.

This passes secrets: inherit, reads the pnpm version from the commit under test, and replaces the five per-platform workflows and four actions with one reusable workflow called per variant. The Vercel deploy now creates the project's root directory before deploying, and the test job gets the build output that the Netlify edge test reads.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 21, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 4a9eb01:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/4a9eb01686f330bb452f0862ee3cd440de1948ad

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17171

@changeset-bot

changeset-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4a9eb01

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nic-Polumeyv
Nic-Polumeyv marked this pull request as draft September 21, 2026 03:03
@Nic-Polumeyv Nic-Polumeyv changed the title chore: pass secrets to the platform test workflows again chore: run each platform test variant through one reusable workflow Sep 21, 2026
@Nic-Polumeyv Nic-Polumeyv changed the title chore: run each platform test variant through one reusable workflow chore: fix and simplify the platform tests Sep 21, 2026
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-node platform tests September 21, 2026 03:26 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-node platform tests September 21, 2026 03:26 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:26 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv had a problem deploying to @sveltejs/adapter-vercel platform tests September 21, 2026 03:27 — with GitHub Actions Failure
@Nic-Polumeyv
Nic-Polumeyv had a problem deploying to @sveltejs/adapter-vercel platform tests September 21, 2026 03:27 — with GitHub Actions Failure
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:27 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:27 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:27 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-node platform tests September 21, 2026 03:36 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-node platform tests September 21, 2026 03:36 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-vercel platform tests September 21, 2026 03:37 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:37 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:37 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:37 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-netlify platform tests September 21, 2026 03:37 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-vercel platform tests September 21, 2026 03:37 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv force-pushed the restore-platform-test-secrets branch 2 times, most recently from 7851eb7 to 9862a39 Compare September 21, 2026 04:09
@Nic-Polumeyv
Nic-Polumeyv marked this pull request as ready for review September 21, 2026 04:12
@Nic-Polumeyv
Nic-Polumeyv force-pushed the restore-platform-test-secrets branch from 5fe325b to 4a9eb01 Compare September 21, 2026 05:05

@teemingc teemingc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much

@teemingc
teemingc merged commit 604dc1f into main Sep 21, 2026
43 of 45 checks passed
@teemingc
teemingc deleted the restore-platform-test-secrets branch September 21, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants