Skip to content

chore: clearer job step names #17176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teemingc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: clearer job step names #17176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7628ff9
Update platform-test.yml
teemingc Sep 21, 2026
8abd233
Apply suggestion from @teemingc
teemingc Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions .github/workflows/platform-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ defaults:

jobs:
build:
name: ${{ inputs.variant }} build
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
Expand Down Expand Up @@ -74,7 +75,8 @@ jobs:
mkdir -p "$APP/.netlify/v1/node_modules/@sveltejs/kit"
cp -r packages/kit/package.json packages/kit/src "$APP/.netlify/v1/node_modules/@sveltejs/kit"

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
- name: Upload build output
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: ${{ inputs.platform }}-${{ inputs.variant }}
# whichever of these the adapter wrote, relative to the test app
Expand All @@ -88,11 +90,13 @@ jobs:

deploy:
needs: build
name: ${{ inputs.variant }} deploy
runs-on: ubuntu-latest
timeout-minutes: 15
environment: '@sveltejs/adapter-${{ inputs.platform }} platform tests'
steps:
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
- name: Get the build output
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: ${{ inputs.platform }}-${{ inputs.variant }}

Expand Down Expand Up @@ -137,7 +141,8 @@ jobs:
env: *vercel-secrets
run: vercel cache purge --type cdn --token="$VERCEL_TOKEN" --yes

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
- name: Store the deployment URL
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
name: ${{ inputs.platform }}-${{ inputs.variant }}-url
path: url
Expand All @@ -146,6 +151,7 @@ jobs:

test:
needs: deploy
name: ${{ inputs.variant }} test
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
Expand All @@ -158,12 +164,14 @@ jobs:
run: pnpm playwright install chromium --no-shell

# some tests inspect the build output
- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
- name: Get the build output
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: ${{ inputs.platform }}-${{ inputs.variant }}
path: ${{ env.APP }}

- uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
- name: Get the deployment URL
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
with:
name: ${{ inputs.platform }}-${{ inputs.variant }}-url
path: ${{ runner.temp }}
Expand Down
Loading