Skip to content

chore: clearer job step names - #17176

Open
teemingc wants to merge 2 commits into
mainfrom
platform-test-step-names
Open

teemingc wants to merge 2 commits into
mainfrom
platform-test-step-names

Conversation

@teemingc

@teemingc teemingc commented Sep 21, 2026 •

Copy link
Copy Markdown
Member

This PR adds names to the job steps so that they're not all the same name such as https://github.com/sveltejs/kit/actions/runs/35619535479/job/106399137528

@pkg-svelte-dev

pkg-svelte-dev Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 8abd233:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/8abd2336e0b5f075b15accca2a0b11be249b1ef1

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17176

@changeset-bot

changeset-bot Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8abd233

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-vercel platform tests September 22, 2026 01:46 — with GitHub Actions Active
@Nic-Polumeyv
Nic-Polumeyv deployed to @sveltejs/adapter-vercel platform tests September 22, 2026 01:46 — with GitHub Actions Active
@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

I'm not seeing this fix the redirect, still 404: https://github.com/sveltejs/kit/actions/runs/35677006218

I think with --prebuilt the file never makes it into the routes, only vercel build merges it into config.json.

@Nic-Polumeyv

Nic-Polumeyv commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Honestly I'd just delete the test... vercel build is what puts those redirects in front of the adapter's routes, so we shouldn't have anything that could break it.

@teemingc

teemingc commented Sep 22, 2026 •

Copy link
Copy Markdown
Member Author

Agree. I'll delete it. d6a7176 (#17164)

@teemingc teemingc changed the title chore: include vercel.json in deployment chore: clearer job step names Sep 22, 2026
Comment thread .github/workflows/platform-test.yml Outdated

This branch was successfully deployed

1 active (outdated) deployment
@sveltejs/adapter-vercel platform tests — 7628ff9e Deployed Sep 22, 2026 by Nic-Polumeyv via vercel / split / split deploy #1348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants