fix(lists): follow every page in list commands that read only the first - #25
Merged
Merged
Conversation
reviews, devices, bundle-ids, profiles (both paths), users, versions, build uploads, Xcode Cloud build runs and diagnostic signatures called Apple without a limit and read one page, so anything past Apple's default page size (50 for most endpoints, 20 for bundle IDs) was dropped. They now request limit=200 and follow every page via APIClient.requestAllPages. Verified live: builds uploads list 50 -> 122, bundle-ids list 20 -> 85; every changed endpoint accepts limit=200. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 9 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (19)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
+ Coverage 81.65% 81.75% +0.09%
==========================================
Files 473 473
Lines 13838 13862 +24
==========================================
+ Hits 11300 11333 +33
+ Misses 2538 2529 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #24, which is stacked on #23. This PR needs the
APIClient.requestAllPageshelper added in #23. Merge #23, then #24, then this one; GitHub retargets each PR as the one below it merges.Problem
These list commands called Apple without a
limitand read a single page. Anything past Apple's default page size was silently dropped: 50 for most endpoints, 20 for bundle IDs.reviews list·devices list·bundle-ids list·profiles list(both with and without--bundle-id-id) ·users list·versions list·builds uploads list·xcode-cloud builds list·diagnostics listFix
Each adapter now requests
limit=200and follows every page throughrequestAllPages. The commands and REST routes are unchanged, and they now return the complete list.Tests
count == 75before the fix.swift testpasses.Live check (read-only, real account)
builds uploads list(app with 101+ builds)bundle-ids listAll the other changed commands ran without errors, which confirms Apple accepts
limit=200on each endpoint.Not in this PR
profiles listwithout--bundle-id-idreturnsbundleIdId: ""for every profile. It reads the linked bundle ID without requesting it viainclude=, the same bug #24 fixes for offer prices.🤖 Generated with Claude Code