Require --author-backend for reviewer and verifier - #6
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7037109d67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (["reviewer", "verifier"].includes(role) && !authorGiven && !(opts.backend && opts.backend !== true) && !opts._composed) { | ||
| die(`--author-backend claude|codex|self is required for --role ${role}: who wrote the diff decides the family. A delegated implementer → its family; a diff the coordinator wrote itself → self.`); |
There was a problem hiding this comment.
When agent-run resume <reviewer-or-verifier-id> --prompt ... is used without redundant routing flags, cmdRun calls resolveRoute before reusing resumeOf.backend, so this condition rejects every such resume for lacking --author-backend. This breaks the documented generic resume workflow for reviewer and verifier sessions; pass the persisted backend into route resolution or exempt resumes from fresh author validation.
Useful? React with 👍 / 👎.
| if (["reviewer", "verifier"].includes(role) && !authorGiven && !(opts.backend && opts.backend !== true) && !opts._composed) { | ||
| die(`--author-backend claude|codex|self is required for --role ${role}: who wrote the diff decides the family. A delegated implementer → its family; a diff the coordinator wrote itself → self.`); |
There was a problem hiding this comment.
When a caller runs route --role reviewer --parent claude --backend claude without --author-backend, this exemption treats the reviewer backend as a substitute for the author's family, silently defaults the author to the preset implementer (codex under auto), and reports the same-family Claude review as independent. The explicit-backend exemption is intended only for run; enforce the new requirement in route even when --backend is present.
Useful? React with 👍 / 👎.
23e2b5d to
618f0a5
Compare
Автор молча подставлялся из implementer'а пресета. Diff, написанный самим координатором на Claude под auto, получал автора codex, ревьюера claude и пометку independent: true — ревью того же семейства выдавалось за независимое (воспроизведено через route --role reviewer --parent claude без флага). Теперь route и run для reviewer и verifier требуют --author-backend claude|codex|self; при явном --backend на run автор не нужен. SKILL.md §6, README, roles.md, review.md — команда без квадратных скобок. Тесты: 5 проверок. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ует автора По ревью PR #6 (Codex P1 ×2): исключение для явного --backend действовало и на route, где по автору считается independent — теперь только для run; resume ревьюера/верификатора падал на проверке автора — семейство берётся из meta прогона. Тесты: 3 проверки, включая resume через заглушку CLI. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
7037109 to
27d518c
Compare
1 participant
Stacked on #5.
Problem
resolveRoutedefaulted the author of a diff to the preset's implementer. A diff the coordinator wrote itself on Claude underautowas therefore attributed tocodex, routed to aclaudereviewer, and markedindependent: true— a same-family review reported as independent. Reproduced withroute --role reviewer --parent claudeand no flag. SKILL.md §6 showed--author-backend selfin square brackets, so the coordinator had no reason to pass it.Change
routeandrunrefuse--role reviewer|verifierwithout--author-backend claude|codex|self; an explicit--backendonrunneeds no author, since the family is already named and independence is not computed there.roles.md,review.md: the flag is part of the command,selfwhen the coordinator wrote the diff.tests/route.sh: 5 refusal/pass-through checks (48 total).Checks
route.sh48/48,caps.sh43/43,delivery.sh25/25,node --check, SKILL.md 7977 bytes.🤖 Generated with Claude Code