Repository navigation
Add FEX 2610-gn-5 to the manifest and make it the default - #2277
Conversation
Series 5 keeps guest loads whose value is unused (GameNative/FEX#8): the dead-flag pass deleted HotSpot's cmp rax,[rdx] null probe, which aborted the JVM in Necesse 13 s after start on every earlier FEX build. Replaces the gn-4 entry as #2211 did for gn3; overlays with a 2610-gn floor resolve to it.
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
Description
Replaces the FEX 2610-gn-4 manifest entry with 2610-gn-5 and makes it the default for new containers, the same way #2211 and #2206 did for gn-4.
Series 5 (GameNative/FEX#8, tag gn-5) keeps guest loads whose value is unused. FEX's dead-flag pass used to delete HotSpot's
cmp rax,[rdx]null probe, so a normal Java null reached the next field load at a pc the JVM has no handler for and the JVM aborted. Necesse died this way 13 s after start on every earlier FEX build and preset; on gn-5 it reaches its menu at 60 fps on stock settings (Odin 3, Proton 11.0-2-arm64ec-9). Any x86 JIT runtime that relies on a faulting probe load (Java, .NET, Mono) is affected the same way.Overlays that pin
minFexVersion: 2610-gn-4resolve to the newest build of the same line, so they move to gn-5 without row edits oncestandard_contentshas the row (utkarshdalal/gamenative-cloudflare-workers#74).The package is the gn-5 tag build on GameNative/FEX (run 40879042858), hosted at https://downloads.gamenative.app/FEXCore-2610-gn-5.wcp (1,332,620 bytes, sha256
751868eb8f6db99ef09146a946c45c981fc11d65eeca58337d5a22e3ef176a5e, profile.json versionName2610-gncode 5).Recording
No recording: manifest entry and default version.
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
Replaces the FEX 2610-gn-4 manifest entry with 2610-gn-5 and makes gn-5 the default FEX build for new containers.
gn-5 keeps guest loads whose value is unused, fixing a JVM crash where FEX's dead-flag pass deleted HotSpot's
cmp rax,[rdx]null probe. The crash aborted Java-runtime games like Necesse 13 seconds after start on every earlier FEX build and preset; on gn-5, Necesse reaches its menu at 60 fps. Any x86 JIT runtime that relies on a faulting probe load (Java, .NET, Mono) benefits the same way.Overlays that pin
minFexVersion: 2610-gn-4resolve to the newest build of the same line, so they move to gn-5 without row edits. Merge after the CDN servesFEXCore-2610-gn-5.wcp.Written for commit 782876d. Summary will update on new commits.
Summary by CodeRabbit