Skip to content

Add FEX 2610-gn-5 to the manifest and make it the default - #2277

Merged
utkarshdalal merged 1 commit into
masterfrom
fex-2610-gn-5
Oct 29, 2026
Merged

utkarshdalal merged 1 commit into
masterfrom
fex-2610-gn-5

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Description

Replaces the FEX 2610-gn-4 manifest entry with 2610-gn-5 and makes it the default for new containers, the same way #2211 and #2206 did for gn-4.

Series 5 (GameNative/FEX#8, tag gn-5) keeps guest loads whose value is unused. FEX's dead-flag pass used to delete HotSpot's cmp rax,[rdx] null probe, so a normal Java null reached the next field load at a pc the JVM has no handler for and the JVM aborted. Necesse died this way 13 s after start on every earlier FEX build and preset; on gn-5 it reaches its menu at 60 fps on stock settings (Odin 3, Proton 11.0-2-arm64ec-9). Any x86 JIT runtime that relies on a faulting probe load (Java, .NET, Mono) is affected the same way.

Overlays that pin minFexVersion: 2610-gn-4 resolve to the newest build of the same line, so they move to gn-5 without row edits once standard_contents has the row (utkarshdalal/gamenative-cloudflare-workers#74).

The package is the gn-5 tag build on GameNative/FEX (run 40879042858), hosted at https://downloads.gamenative.app/FEXCore-2610-gn-5.wcp (1,332,620 bytes, sha256 751868eb8f6db99ef09146a946c45c981fc11d65eeca58337d5a22e3ef176a5e, profile.json versionName 2610-gn code 5).

Recording

No recording: manifest entry and default version.

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

Replaces the FEX 2610-gn-4 manifest entry with 2610-gn-5 and makes gn-5 the default FEX build for new containers.

gn-5 keeps guest loads whose value is unused, fixing a JVM crash where FEX's dead-flag pass deleted HotSpot's cmp rax,[rdx] null probe. The crash aborted Java-runtime games like Necesse 13 seconds after start on every earlier FEX build and preset; on gn-5, Necesse reaches its menu at 60 fps. Any x86 JIT runtime that relies on a faulting probe load (Java, .NET, Mono) benefits the same way.

Overlays that pin minFexVersion: 2610-gn-4 resolve to the newest build of the same line, so they move to gn-5 without row edits. Merge after the CDN serves FEXCore-2610-gn-5.wcp.

Written for commit 782876d. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Updates
    • Updated the available FEXCore version to 2610-gn-5. The matching package is now selected for downloads and installations, replacing version 2610-gn-4.

Series 5 keeps guest loads whose value is unused (GameNative/FEX#8): the
dead-flag pass deleted HotSpot's cmp rax,[rdx] null probe, which aborted the
JVM in Necesse 13 s after start on every earlier FEX build. Replaces the gn-4
entry as #2211 did for gn3; overlays with a 2610-gn floor resolve to it.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The default FEXCore version changes to 2610-gn-5. The manifest entry now uses the same version ID, display name, and download URL.

Changes: FEXCore version update

Layer / File(s) Summary
Update default version and manifest
app/src/main/java/com/winlator/core/DefaultVersion.java, manifest.json
The default FEXCore version and manifest entry change from 2610-gn-4 to 2610-gn-5. The manifest display name and download URL also match the new version.

Priority: Not assessed

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Possibly related PRs

  • utkarshdalal/GameNative#2206: This PR made FEXCore 2610-gn-4 the default for new containers. This change updates that default to 2610-gn-5.

Suggested reviewers: phobos665

Merge Risk: Moderate · up to 78287

This change makes FEX 2610-gn-5 the default, but new containers may show or select a different FEXCore version, or fail to fetch gn-5 for up to a day if the manifest is cached. Containers that persist gn-4 also lose the ability to re-download it. Confirm the selection and download behavior, and that the CDN file is live, before merging.

Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@utkarshdalal
utkarshdalal merged commit f765e21 into master Oct 29, 2026
3 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Nov 6, 2026
4 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant