Repository navigation
Fix digest, sign and verify length handling - #241
Open
aidangarske wants to merge 160 commits into
Open
aidangarske wants to merge 160 commits into
aidangarske wants to merge 160 commits into
Conversation
18 tasks
aidangarske
force-pushed
the
fenrir-fixes-2786-3639
branch
2 times, most recently
from
October 9, 2026 02:00
6a7c941 to
6250e3a
Compare
aidangarske
force-pushed
the
fenrir-fixes-2786-3639
branch
from
October 10, 2026 03:20
6250e3a to
7e96568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-2040- 24c189a - C_Digest now checks for an active digest operation with WP11_INIT_DIGEST, like C_DigestUpdate and C_DigestFinal.F-2786- 201e498 - C_Digest, C_DigestUpdate, C_Sign, C_SignUpdate, C_Verify, C_VerifyUpdate and the RSA paths of C_Encrypt and C_Decrypt now reject lengths that do not fit in 32 bits and end the operation through WP11_Session_AbortOp.F-2787- 44603f1 - The HMAC and CMAC paths of C_VerifyFinal now return CKR_SIGNATURE_LEN_RANGE for a signature length of 2^32 or more and abort the operation.F-5155- 6cee715 - C_Sign and C_SignFinal now compare the output length as a CK_ULONG, and CMAC and TLS MAC capacities are capped with CK_ULONG_CAP_WORD32.F-3639- b228e70 - The CKR_BUFFER_TOO_SMALL paths in encrypt, decrypt and sign, and WP11_Aes_Cmac_Check_Len, now write the required output length first.F-3836- 1837d67 - WP11_Digest_Single now sets the output length on BUFFER_E and keeps the operation active so the call can be retried.F-3837- daf2709 - WP11_Digest_Final now sets the output length on BUFFER_E.F-5154- 4bf34a8 - C_Digest and C_DigestFinal now cap the output buffer length with CK_ULONG_CAP_WORD32.F-2377- 863ce5a - C_Digest and C_DigestUpdate now accept zero-length input and only validate pointers, with a NULL data pointer still returning CKR_ARGUMENTS_BAD.F-2782- 6250e3a - C_DigestKey now hashes the secret key's CKA_VALUE and returns CKR_KEY_INDIGESTIBLE for other object classes or unsupported key types, ending the operation on every error exit.