Repository navigation
Zeroize transient MAC, AES and RNG buffers - #242
Merged
Merged
Conversation
aidangarske
force-pushed
the
fenrir-fixes-2391-2392
branch
2 times, most recently
from
October 9, 2026 02:00
c3bee70 to
355c5ef
Compare
aidangarske
changed the title
aidangarske
force-pushed
the
fenrir-fixes-2391-2392
branch
from
October 10, 2026 03:20
355c5ef to
39ffb0d
Compare
Frauschi
reviewed
Oct 13, 2026
aidangarske
force-pushed
the
fenrir-fixes-2391-2392
branch
from
October 13, 2026 22:19
39ffb0d to
620bb0c
Compare
aidangarske
force-pushed
the
fenrir-fixes-2391-2392
branch
4 times, most recently
from
October 13, 2026 23:46
44afd57 to
8268dc3
Compare
Frauschi
previously approved these changes
Oct 14, 2026
Frauschi
left a comment
Frauschi
left a comment
Member
There was a problem hiding this comment.
Thanks. You're right about cbc.final, it's inline in session->params and wp11_Session_FreeOp zeroes that, so my comment was wrong. The allocator guard fix looks good.
aidangarske
force-pushed
the
fenrir-fixes-2391-2392
branch
2 times, most recently
from
October 15, 2026 16:53
492fd3d to
2e3227e
Compare
Frauschi
previously approved these changes
Oct 15, 2026
aidangarske
dismissed
Frauschi’s stale review
October 15, 2026 20:36
The merge-base changed after approval.
aidangarske
force-pushed
the
fenrir-fixes-2391-2392
branch
from
October 15, 2026 21:03
2e3227e to
a54ffaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-8661- 9690551 - Rng_New now zeroizes its DRBG seed buffer with wc_ForceZero on both return paths.F-2393- 8c54315 - The buffered AES-CBC partial block is now zeroized in the CBC and CBC-PAD finals and in wp11_Session_Final.F-6494- f5804d5 - WP11_AesGcm_EncryptFinal now zeroizes the buffered plaintext before freeing it, and wp11_AesGcm_BufferAppend grows by allocate, copy, zeroize, free instead of realloc.F-2391- 304a290 - WP11_Hmac_Verify and WP11_Hmac_VerifyFinal now zeroize the computed HMAC with wc_ForceZero after comparing.F-2392- 2e86a1f - WP11_Aes_Cmac_Verify and WP11_Aes_Cmac_Verify_Final now zeroize the computed CMAC tag with wc_ForceZero after comparing.F-2394- 355c5ef - WP11_TLS_MAC_verify now zeroizes the computed TLS MAC with wc_ForceZero before freeing it.