Repository navigation
Conversation
NEXT.md's Phase 1 exit says an app that reaches for parent.document or the host's localStorage fails. sandbox-isolation.spec.ts installs a probe app that tries both on mount and reports what it got to /__probe, read at the network layer so the check doesn't depend on how 1.2 mounts apps. The isolation test is test.fail() until the sandboxed runner lands; a control test proves the probe runs. support/desktop.ts gains installApp and openApp hook helpers, and the e2e README describes expected-fail specs. Closes #134. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEXT.md's Phase 1 exit says "an app that reaches for
parent.documentor the host'slocalStoragefails". Nothing checks that today, so this adds the check now, ahead of the code that will meet it.tests/e2e/sandbox-isolation.spec.ts:localStorageandwindow.parent.documenton mount, and reports what it got to/__probe;test.fail()until 1.2, so CI stays green while the gap is open.test.fail()line in the 1.2 PR. If 1.2 changes how app code can reach the network, the control is the part to adjust.support/desktop.tsgainsinstallAppandopenApphook helpers.tests/e2e/README.mdgets a short section on expected-fail specs.@Sullux, this is meant as a ready target for 1.2; happy to reshape it to match the bridge you have in mind.
Closes #134.
Verification
Each run merged the branch into current
main(d2f3679) in a clean container:tsc -p tests/e2eandeslint tests/e2eare clean.test.fail()removed, the isolation test fails for the right reason:Expected substring: not "e2e-planted-key-isolation-probe",Received string: "{"provider":"openai",…,"apiKey":"e2e-planted-key-isolation-probe",…}".So today an app can read the stored key.
🤖 Generated with Claude Code