Repository navigation
One word_report table for learners' reports about a word - #914
Merged
Merged
Conversation
Replaces exercise_report and meaning_report (roadmap 0c, step 1). A report keeps the word, the meaning it had, and the sentence it was shown in; the kind says whether the meaning or the sentence is wrong. "Bad translation" in the remove dialog now files a report too, besides the skip. The endpoints are unchanged on the wire: old reasons are mapped (context_wrong and bad_examples -> bad_example, wrong_meaning -> wrong_translation). Migration 26-10-25-b moves the 47 old rows in, fills the sentence from the bookmark where the client didn't send it, and drops the two old tables. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
ArchLens detected architectural changes in the following views: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap 0c, step 1 (
docs/future-work/llm-tasks-roadmap.md). Nothing new happens on a report yet. The next PR makes awrong_translationreport run the validator.What changes
word_reporttable: user, meaning, user word, bookmark, the sentence shown (a copy of its text), origin (exercise/reader/word_list), exercise source, kind, comment.user_word_idandbookmark_idareON DELETE SET NULL, so a report outlives a validator fix or a deleted bookmark./report_exercise_issueand/report_meaningwrite to it; their requests and responses are unchanged.context_wrongandbad_examplesbecomebad_example,wrong_meaningbecomeswrong_translation./dont_use_in_exerciseswith reasonbad_translationnow also files awrong_translationreport. The learner still getsskip.ExerciseReportandMeaningReportare removed; account deletion and account merge handleword_report.Migration
tools/migrations/26-10-25-b--word_report.sql[object Object],…(3, all from before 12 Mar).exercise_reportandmeaning_report.Tested on local MySQL without the DROPs: 35/35 rows copied, every exercise report has a sentence. 1350 tests pass.
🤖 Generated with Claude Code