Conversation
This change moves the ConnectionManager release call out of the critical section in Connection::close(). The connection lock is now cleared before releasing the connection back to the manager, avoiding lock-ordering and re-entrancy issues while the socket is being torn down.
Capture the active protocol before calling onSendMessage while the worker lock is released. This prevents dereferencing a stale or replaced protocol pointer during message sending and avoids potential use-after-free issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves the ConnectionManager release call out of the critical section in Connection::close(). The connection lock is now cleared before releasing the connection back to the manager, avoiding lock-ordering and re-entrancy issues while the socket is being torn down.
Fix protocol send callback race
Capture the active protocol before calling onSendMessage while the worker lock is released. This prevents dereferencing a stale or replaced protocol pointer during message sending and avoids potential use-after-free issues.