Skip to content

fix: Use-After-Free in Connection::close() #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jprzimba wants to merge 2 commits into from
Closed

fix: Use-After-Free in Connection::close() #936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6991197
Fix connection release ordering
jprzimba Sep 11, 2026
7256e61
Fix protocol send callback race
jprzimba Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/server/network/connection/connection.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,7 @@ Connection::Connection(asio::io_service &initIoService, ConstServicePort_ptr ini
}

void Connection::close(bool force) {
ConnectionManager::getInstance().releaseConnection(shared_from_this());

std::scoped_lock lock(connectionLock);
std::unique_lock lock(connectionLock);
ip = 0;

if (connectionState == CONNECTION_STATE_CLOSED) {
Expand All @@ -84,6 +82,9 @@ void Connection::close(bool force) {
if (messageQueue.empty() || force) {
closeSocket();
}

lock.unlock();
ConnectionManager::getInstance().releaseConnection(shared_from_this());
}

void Connection::closeSocket() {
Expand Down Expand Up @@ -371,8 +372,9 @@ void Connection::internalWorker() {
}

const auto &outputMessage = messageQueue.front();
auto currentProtocol = protocol;
lock.unlock();
protocol->onSendMessage(outputMessage);
currentProtocol->onSendMessage(outputMessage);
lock.lock();

internalSend(outputMessage);
Expand Down
Loading