Skip to content

Boost: Share an Except panel across modern Settings exclusions - #52564

Merged
LiamSarsfield merged 4 commits into
trunkfrom
fm/boost-748-settings-except-panel
Sep 22, 2026
Merged

LiamSarsfield merged 4 commits into
trunkfrom
fm/boost-748-settings-except-panel

Conversation

@LiamSarsfield

@LiamSarsfield LiamSarsfield commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes BOOST-748

Proposed changes

Use one Except panel for Defer JS, Concatenate JS/CSS, and Page Cache exclusions in modern Settings. Keep existing inputs, help, Save handlers, and Load default handles. Clear Cache and logging stay in their existing options area.

Legacy presentation is unchanged: rendering is guarded by the row surface. Collapsed and expanded legacy Settings DOM matched byte-for-byte; before/after screenshots at 1280 and 782 had zero differing pixels.

Related product discussion/links

See the ticket above.

Does this pull request change what data or activity we track or use?

Yes. The modern Page Cache Except toggle sends boost_page_cache_except_panel_toggle; Show Options keeps its existing event. No new properties.

Testing instructions

Enable rsm_jetpack_ui_modernization_boost, open Settings, and enable the four modules. Expand each Except panel, edit exclusions, save, and reload. Check unchanged values disable Save, invalid cache patterns cannot save, and default handles still load. Repeat with the filter off.

Production build, 20 focused tests, typecheck, ESLint, and Stylelint pass.

Reuse check

Reuse CollapsibleMeta state/events, existing forms, chevrons, and WordPress surface/spacing tokens; the existing cache-log well provides the styling precedent.

Screenshots 1280 782
Modern expanded View View
Modern collapsed View View
Modern RTL View View
Legacy collapsed Before / After Before / After
Legacy expanded Before / After Before / After

@LiamSarsfield
LiamSarsfield requested a review from a team as a code owner September 21, 2026 17:11
@LiamSarsfield
LiamSarsfield marked this pull request as draft September 21, 2026 17:12
@LiamSarsfield LiamSarsfield changed the title fix(boost): unify modern settings exclusion panels Boost: Unify modern settings exclusion panels Sep 21, 2026
@github-actions github-actions Bot added [Plugin] Boost A feature to speed up the site and improve performance. Docs labels Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Sep 21, 2026
@jp-launch-control

jp-launch-control Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 8 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/assets/src/js/svg/chevron-down.tsx 2/2 (100.00%) 100.00% -2 💚
projects/plugins/boost/app/assets/src/js/svg/chevron-up.tsx 2/2 (100.00%) 100.00% -2 💚
projects/plugins/boost/app/assets/src/js/svg/lightning.tsx 2/2 (100.00%) 100.00% -2 💚
projects/plugins/boost/app/assets/src/js/lib/stores/minify.ts 7/10 (70.00%) 70.00% -7 💚
projects/plugins/boost/app/assets/src/js/features/ui/collapsible-meta/collapsible-meta.tsx 13/13 (100.00%) 100.00% -10 💚

1 file is newly checked for coverage.

File Coverage
projects/plugins/boost/app/assets/src/js/features/ui/collapsible-meta/except-panel.tsx 6/6 (100.00%) 💚

Full summary · PHP report · JS report

@LiamSarsfield LiamSarsfield changed the title Boost: Unify modern settings exclusion panels Boost: Share an Except panel across modern Settings exclusions Sep 21, 2026
@LiamSarsfield LiamSarsfield added the [Status] Needs Privacy Updates Our support docs will need to be updated to take this change into account label Sep 21, 2026
@LiamSarsfield
LiamSarsfield force-pushed the fm/boost-748-settings-except-panel branch from 078adae to 75d78d0 Compare September 21, 2026 19:40
@LiamSarsfield
LiamSarsfield force-pushed the fm/boost-748-settings-except-panel branch from 75d78d0 to 3d99c50 Compare September 21, 2026 20:17
@LiamSarsfield
LiamSarsfield marked this pull request as ready for review September 22, 2026 08:06
@LiamSarsfield LiamSarsfield removed [Status] Needs Privacy Updates Our support docs will need to be updated to take this change into account [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Sep 22, 2026
@LiamSarsfield
LiamSarsfield merged commit d3d1ace into trunk Sep 22, 2026
93 checks passed
@LiamSarsfield
LiamSarsfield deleted the fm/boost-748-settings-except-panel branch September 22, 2026 08:06
@github-actions github-actions Bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] In Progress labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs [Plugin] Boost A feature to speed up the site and improve performance. [Status] UI Changes Add this to PRs that change the UI so documentation can be updated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant