Repository navigation
Boost: Share an Except panel across modern Settings exclusions - #52564
Merged
Merged
Conversation
LiamSarsfield
marked this pull request as draft
September 21, 2026 17:12
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 8 files. Only the first 5 are listed here.
1 file is newly checked for coverage.
|
LiamSarsfield
force-pushed
the
fm/boost-748-settings-except-panel
branch
from
September 21, 2026 19:40
078adae to
75d78d0
Compare
LiamSarsfield
force-pushed
the
fm/boost-748-settings-except-panel
branch
from
September 21, 2026 20:17
75d78d0 to
3d99c50
Compare
LiamSarsfield
marked this pull request as ready for review
September 22, 2026 08:06
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BOOST-748
Proposed changes
Use one Except panel for Defer JS, Concatenate JS/CSS, and Page Cache exclusions in modern Settings. Keep existing inputs, help, Save handlers, and Load default handles. Clear Cache and logging stay in their existing options area.
Legacy presentation is unchanged: rendering is guarded by the row surface. Collapsed and expanded legacy Settings DOM matched byte-for-byte; before/after screenshots at 1280 and 782 had zero differing pixels.
Related product discussion/links
See the ticket above.
Does this pull request change what data or activity we track or use?
Yes. The modern Page Cache Except toggle sends
boost_page_cache_except_panel_toggle; Show Options keeps its existing event. No new properties.Testing instructions
Enable
rsm_jetpack_ui_modernization_boost, open Settings, and enable the four modules. Expand each Except panel, edit exclusions, save, and reload. Check unchanged values disable Save, invalid cache patterns cannot save, and default handles still load. Repeat with the filter off.Production build, 20 focused tests, typecheck, ESLint, and Stylelint pass.
Reuse check
Reuse CollapsibleMeta state/events, existing forms, chevrons, and WordPress surface/spacing tokens; the existing cache-log well provides the styling precedent.