Repository navigation
Boost: Add upgrade notices and a manual Critical CSS Generate step - #52567
Merged
Merged
Conversation
LiamSarsfield
marked this pull request as draft
September 21, 2026 17:28
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 19 files. Only the first 5 are listed here.
1 file is newly checked for coverage.
|
…ty-context _x() calls, preserving copy and behavior. Reproduced the original failure; production webpack now passes, along with 5 focused tests and ESLint. Full production build remains locally blocked by missing built Components and Boost Score API dependencies
…cting automatic generation. Updated it to assert and click the required Generate button. ESLint, e2e typecheck, and 10 focused unit tests pass. Local Playwright execution was blocked by the missing test-site URL/tunnel configuration
LiamSarsfield
marked this pull request as ready for review
September 22, 2026 08:05
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BOOST-749
Proposed changes
Modern Settings shows Critical CSS, Image CDN, and Cornerstone upsells as info notices without monthly prices. Enabling free manual Critical CSS now waits for Generate, adding a deliberate step; legacy auto-start and paid automatic CSS stay unchanged. After invalidation, a free modern site serves no Critical CSS until Generate is pressed. A status well shows progress and results, with partial failures in a warning notice.
Related product discussion/links
Desktop comparison · Mobile comparison · Design comparison · RTL
Does this pull request change what data or activity we track or use?
No. Existing upgrade tracking and the Boost interstitial destination are unchanged.
Testing instructions
rsm_jetpack_ui_modernization_booston a free site. Enable manual Critical CSS, then click Generate. Check idle, progress, completed, and partial-failure states; follow the recommendations link.Verified locally with
SCRIPT_DEBUG=false: manual states, 447 Jest tests, typecheck, ESLint, and Stylelint. Legacy code paths and shared translation strings are unchanged. Rendered legacy Settings HTML is identical; screenshots at 1280 and 782 are pixel-identical.Follow-up
The well’s info icon is deliberately omitted until tooltip copy is supplied.
Reuse check
Reuse
@wordpress/uiNotice, Button, Stack, and Text, plus the existing progress bar and generation action. No shared well exists; its tokens follow the cache-log surface.