Skip to content

Boost: Add upgrade notices and a manual Critical CSS Generate step - #52567

Merged
LiamSarsfield merged 6 commits into
trunkfrom
fm/boost-749-upsells-css-well
Sep 22, 2026
Merged

LiamSarsfield merged 6 commits into
trunkfrom
fm/boost-749-upsells-css-well

Conversation

@LiamSarsfield

@LiamSarsfield LiamSarsfield commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixes BOOST-749

Proposed changes

Modern Settings shows Critical CSS, Image CDN, and Cornerstone upsells as info notices without monthly prices. Enabling free manual Critical CSS now waits for Generate, adding a deliberate step; legacy auto-start and paid automatic CSS stay unchanged. After invalidation, a free modern site serves no Critical CSS until Generate is pressed. A status well shows progress and results, with partial failures in a warning notice.

Related product discussion/links

Desktop comparison · Mobile comparison · Design comparison · RTL

Does this pull request change what data or activity we track or use?

No. Existing upgrade tracking and the Boost interstitial destination are unchanged.

Testing instructions

  • Enable rsm_jetpack_ui_modernization_boost on a free site. Enable manual Critical CSS, then click Generate. Check idle, progress, completed, and partial-failure states; follow the recommendations link.
  • Check all three upsells at desktop/mobile widths and RTL. Offline sites must hide them.
  • Disable the filter and check the legacy dashboard.

Verified locally with SCRIPT_DEBUG=false: manual states, 447 Jest tests, typecheck, ESLint, and Stylelint. Legacy code paths and shared translation strings are unchanged. Rendered legacy Settings HTML is identical; screenshots at 1280 and 782 are pixel-identical.

Follow-up

The well’s info icon is deliberately omitted until tooltip copy is supplied.

Reuse check

Reuse @wordpress/ui Notice, Button, Stack, and Text, plus the existing progress bar and generation action. No shared well exists; its tokens follow the cache-log surface.

@LiamSarsfield
LiamSarsfield requested a review from a team as a code owner September 21, 2026 17:27
@LiamSarsfield
LiamSarsfield marked this pull request as draft September 21, 2026 17:28
@LiamSarsfield LiamSarsfield changed the title feat(boost): add modern upgrade notices and Critical CSS status well Boost: Add upgrade notices and a manual Critical CSS Generate step Sep 21, 2026
@github-actions github-actions Bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Sep 21, 2026
@jp-launch-control

jp-launch-control Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 19 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/assets/src/js/features/critical-css/critical-css-meta/critical-css-meta.tsx 15/15 (100.00%) 0.00% 0 💚
projects/plugins/boost/app/assets/src/js/features/critical-css/critical-css-module/critical-css-module.tsx 8/8 (100.00%) 0.00% 0 💚
projects/plugins/boost/app/assets/src/js/features/upgrade-cta/upgrade-cta.tsx 13/14 (92.86%) 1.95% 0 💚
projects/plugins/boost/app/assets/src/js/features/critical-css/critical-css-context/critical-css-context-provider.tsx 45/59 (76.27%) 1.69% -1 💚
projects/plugins/boost/app/assets/src/js/features/critical-css/error-description/error-description.tsx 1/14 (7.14%) 7.14% -1 💚

1 file is newly checked for coverage.

File Coverage
projects/plugins/boost/app/assets/src/js/features/critical-css/critical-css-meta/modern-critical-css-status.tsx 12/12 (100.00%) 💚

Full summary · PHP report · JS report

…ty-context _x() calls, preserving copy and behavior. Reproduced the original failure; production webpack now passes, along with 5 focused tests and ESLint. Full production build remains locally blocked by missing built Components and Boost Score API dependencies
…cting automatic generation. Updated it to assert and click the required Generate button. ESLint, e2e typecheck, and 10 focused unit tests pass. Local Playwright execution was blocked by the missing test-site URL/tunnel configuration
@LiamSarsfield
LiamSarsfield marked this pull request as ready for review September 22, 2026 08:05
@LiamSarsfield
LiamSarsfield merged commit d48b67d into trunk Sep 22, 2026
113 of 114 checks passed
@LiamSarsfield
LiamSarsfield deleted the fm/boost-749-upsells-css-well branch September 22, 2026 08:06
@github-actions github-actions Bot added [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E2E Tests [Plugin] Boost A feature to speed up the site and improve performance. [Status] UI Changes Add this to PRs that change the UI so documentation can be updated. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant