Repository navigation
Correct Setup admission design for deletion and atomic storage - #86
Merged
Merged
Conversation
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The earlier Setup design relied on deleted root-Session history to suppress repeated automatic effects and placed attempts in an aggregate that normal Session deletion purges. It also assumed the single-aggregate
Store::append_checkedAPI could atomically persist Session creation and an independently owned marker.Correct the design to retain installation/Location markers, attempt settlement and request deduplication outside deleted Session aggregates. Specify a bounded multi-aggregate checked-append prerequisite with complete rollback and post-commit notification guarantees. Record that legacy deletion leaves incomplete evidence, so the complete migration/support decision needs review before schema or init implementation. Expand the required deletion, rebuild, retry and transaction-failure tests.
This is a one-document correction against current main, independent of PR #85. Setup tasks S1–S6 remain unchecked; the Store epoch/key and legacy-bootstrap decisions remain proposed. No marker, migration, Store API, CLI/API or dispatch behavior is implemented.
Validation: