Repository navigation
Verify FileChanged acceptance and specify directory admission - #85
Merged
Merged
Conversation
This was referenced Oct 31, 2026
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two FileChanged alias-retarget regressions previously compiled only on Unix, leaving Windows without direct coverage for revoking old-root delivery and refusing an unused old-root user acknowledgement. Use native directory symlinks and platform-correct link removal so the same assertions execute on Windows.
Add a requirement-by-requirement FileChanged acceptance audit and source-bound platform receipts. Retain PR #84's corrected macOS datagram verifier reports with verified archive/source/control bindings. Those reports accept the verifier correction; native plugin admission and the historical unknown race cause remain open.
Document the DirectoryAdded prerequisite for review: durable Session directory admission must publish ordinary file scope, native sandbox roots and instruction Context Sources together before emitting a committed hook. Its choices and D1–D6 tasks remain proposed. The merged Setup and CwdChanged task additions are both retained after resolving the ledger conflict against current main.
Bound each
cinextest attempt with the existing Windows ten-minute slow timeout, retaining the single retry. The superseded Linux job was cancelled by concurrency after the required main integration; its log showedmessages_cli::stats_separate_message_driven_usagestill running beyond 9,180 seconds. The cause remains unverified. The timeout change makes future stalls fail within a bounded attempt rather than claiming an application fix.Validation:
ci-windows, and both profiles retain one retry. A retried case can consume two attempts.Task 5.2 stays open pending current checks and final merge review. DirectoryAdded/Setup, native plugin enforcement/protocol work, daily coding and binary editor requirements remain open.
Current broad results: Linux passed 5,504 cases (21 skipped), and Windows passed 3,775 selected cases (648 skipped), plus metadata (4), migration (9), and AppContainer (18) checks. Both checked out merge
151144ea4f94f53866710ff9a25d74d64ca6a605, whose tree equals this head. Windows reported one leaked-process warning inmessages_cli::an_exec_session_refuses_messages_unless_it_accepts_them; cause unverified. The previously stalled stats case passed in 2.299 seconds on Linux and 17.731 seconds on Windows in these runs; this does not establish the earlier stall cause or an application fix. macOS broad acceptance remains pending.Main integration review after #88: prospective merge tree
ad445cb227b0a7d1cc8593cc25d7cd3efc4b9e3fagainst accepted main9cbbf08b3382622625335210360928a729a47e33differs from this PR head only inworktree_setup.rsand the task ledger. The FileChanged test files and nextest configuration remain byte-identical to this PR's tested head;worktree_setup.rsis byte-identical to accepted #88. No production source differs between these compositions. The exact composed tree passes formatting, whitespace, strict OpenSpec (114/0), and spec lint (0 errors/25 warnings). This composition review supplements the separate source-bound platform results; it does not claim the full composed workspace suite was rerun. The temporary local merge was aborted after verification.Final current-head acceptance: all 19 checks passed. The macOS workspace job passed 5,504 cases (23 skipped, 2 slow), with no test failures or retries reported. The stats case passed in 2.604 seconds; its earlier stall cause remains unverified. The API still advertises the earlier tested base/merge; current main is
9cbbf08b3382622625335210360928a729a47e33. The separately verified current-main composition is treead445cb227b0a7d1cc8593cc25d7cd3efc4b9e3f, with the source bindings and checks described above. Review found no blocking issue in this change. Task 5.2 remains open for final retained acceptance reconciliation; other goal obligations remain open.