Skip to content

Verify FileChanged acceptance and specify directory admission - #85

Merged
vanedaltro merged 8 commits into
mainfrom
test/file-observer-windows-alias-acceptance
Oct 31, 2026
Merged

vanedaltro merged 8 commits into
mainfrom
test/file-observer-windows-alias-acceptance

Conversation

@vanedaltro

@vanedaltro vanedaltro commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Two FileChanged alias-retarget regressions previously compiled only on Unix, leaving Windows without direct coverage for revoking old-root delivery and refusing an unused old-root user acknowledgement. Use native directory symlinks and platform-correct link removal so the same assertions execute on Windows.

Add a requirement-by-requirement FileChanged acceptance audit and source-bound platform receipts. Retain PR #84's corrected macOS datagram verifier reports with verified archive/source/control bindings. Those reports accept the verifier correction; native plugin admission and the historical unknown race cause remain open.

Document the DirectoryAdded prerequisite for review: durable Session directory admission must publish ordinary file scope, native sandbox roots and instruction Context Sources together before emitting a committed hook. Its choices and D1–D6 tasks remain proposed. The merged Setup and CwdChanged task additions are both retained after resolving the ledger conflict against current main.

Bound each ci nextest attempt with the existing Windows ten-minute slow timeout, retaining the single retry. The superseded Linux job was cancelled by concurrency after the required main integration; its log showed messages_cli::stats_separate_message_driven_usage still running beyond 9,180 seconds. The cause remains unverified. The timeout change makes future stalls fail within a bounded attempt rather than claiming an application fix.

Validation:

  • Latest local formatting/whitespace checks pass. Strict OpenSpec: 114 passed, 0 failed; spec lint: 0 errors, 25 warnings.
  • Nextest 0.9.149 accepts the configuration. The timeout matches ci-windows, and both profiles retain one retry. A retried case can consume two attempts.
  • Historical focused Linux/macOS/Windows runs at 01535d4 and ecce8b3 passed both retarget cases, with 17 Store/runtime and 24 HTTP cases per platform. Actual checkout/log/tree bindings are retained in the evidence. The two FileChanged test files remain byte-identical to ecce8b3 after main integration; the accepted CwdChanged test file matches main.
  • Both retarget cases and scoped Clippy passed locally on macOS on that earlier test-source revision. Windows execution is unavailable locally.
  • The earlier Windows broad job passed 3,775 selected tests with 648 skips and one leaky-test warning; it is historical evidence, not acceptance of this updated revision.
  • Current-head focused jobs passed on Linux, macOS, and Windows. Independently inspected logs execute both named retarget cases successfully, with 17 Store/runtime and 24 HTTP cases per platform. All eight focused suites pass on each platform; Unix ignored subprocess-entry helpers are exercised by their parent cases. The current macOS broad workspace check remains running. The full local Rust workspace suite was not run for this documentation/configuration update.

Task 5.2 stays open pending current checks and final merge review. DirectoryAdded/Setup, native plugin enforcement/protocol work, daily coding and binary editor requirements remain open.

Current broad results: Linux passed 5,504 cases (21 skipped), and Windows passed 3,775 selected cases (648 skipped), plus metadata (4), migration (9), and AppContainer (18) checks. Both checked out merge 151144ea4f94f53866710ff9a25d74d64ca6a605, whose tree equals this head. Windows reported one leaked-process warning in messages_cli::an_exec_session_refuses_messages_unless_it_accepts_them; cause unverified. The previously stalled stats case passed in 2.299 seconds on Linux and 17.731 seconds on Windows in these runs; this does not establish the earlier stall cause or an application fix. macOS broad acceptance remains pending.

Main integration review after #88: prospective merge tree ad445cb227b0a7d1cc8593cc25d7cd3efc4b9e3f against accepted main 9cbbf08b3382622625335210360928a729a47e33 differs from this PR head only in worktree_setup.rs and the task ledger. The FileChanged test files and nextest configuration remain byte-identical to this PR's tested head; worktree_setup.rs is byte-identical to accepted #88. No production source differs between these compositions. The exact composed tree passes formatting, whitespace, strict OpenSpec (114/0), and spec lint (0 errors/25 warnings). This composition review supplements the separate source-bound platform results; it does not claim the full composed workspace suite was rerun. The temporary local merge was aborted after verification.

Final current-head acceptance: all 19 checks passed. The macOS workspace job passed 5,504 cases (23 skipped, 2 slow), with no test failures or retries reported. The stats case passed in 2.604 seconds; its earlier stall cause remains unverified. The API still advertises the earlier tested base/merge; current main is 9cbbf08b3382622625335210360928a729a47e33. The separately verified current-main composition is tree ad445cb227b0a7d1cc8593cc25d7cd3efc4b9e3f, with the source bindings and checks described above. Review found no blocking issue in this change. Task 5.2 remains open for final retained acceptance reconciliation; other goal obligations remain open.

@vanedaltro
vanedaltro merged commit 5d5826b into main Oct 31, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant