Repository navigation
Keep passwords out of local echo and transcripts (#125, finished) - #128
Merged
Merged
Conversation
Honor Telnet ECHO negotiation so standalone password responses stay out of local scrollback, transcripts, and command history. Resume normal local echo when the server sends WONT ECHO. Reuse the existing credential detector to redact local echoes of commands such as connect <name> <password>.
A typed line is now judged for credentials as typed: each physical line, and each stacked piece with its #N repeat stripped, so `look;#1 connect Corvid pw` (sent or refused) stays out of history and the echo. One rule, HistorySecrets.CarriesCredential, serves both. Also moves a doc comment #125 left on the wrong test, and adds the changelog entry the Changelog workflow requires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rqqt7WwMmhxVJpERSzReCy
|
Caution Review failedThe pull request is closed.
|
HarryCordewener
marked this pull request as ready for review
November 11, 2026 00:19
HarryCordewener
pushed a commit
that referenced
this pull request
Nov 11, 2026
4.11.0 answers a server's WONT ECHO with DONT ECHO when it was echoing and stops answering a repeated WILL ECHO (RFC 1143), which matters at a password prompt now that local echo follows the server's ECHO state (#128). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Rqqt7WwMmhxVJpERSzReCy
HarryCordewener
added a commit
that referenced
this pull request
Nov 11, 2026
4.11.0 answers a server's WONT ECHO with DONT ECHO when it was echoing and stops answering a repeated WILL ECHO (RFC 1143), which matters at a password prompt now that local echo follows the server's ECHO state (#128). Claude-Session: https://claude.ai/code/session_01Rqqt7WwMmhxVJpERSzReCy Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Grave · project thread
Merges @nickrobnett's #125 unchanged (its commit
98b07ecis kept, so #125 shows as merged), then finishes it:HistorySecrets.CarriesCredential(line, separator)judges a line as typed: every physical line, and every stacked piece with its#Nrepeat stripped. History and the local echo both use it, solook;#1 connect X pwand the refusedlook;#101 connect X pware kept out of history and shown as(credential command hidden). This is the gap raised in review on Keep passwords out of local echo and session transcripts #125.Checked against RFC 857: while the server has
WILL ECHO, the client stops its local echo; the client never agrees toDO ECHOitself, so no echo loop.EchoProtocolin client mode initiates nothing (TNC 4.9.0), so the no-unsolicited-negotiation rule holds.Verification: Release build 0 warnings; Core 1757/1758 (the one failure is
AReadOnlyCacheDirectory_DegradesToMemoryOnly, which fails only when run as root); Tui 3041/3041.Generated by Claude Code