Skip to content

feat(ui): add W64 operational analytics parity - #247

Merged
ammarheidari merged 1 commit into
mainfrom
w64-operator-ui-parity
Oct 4, 2026
Merged

ammarheidari merged 1 commit into
mainfrom
w64-operator-ui-parity

Conversation

@ammarheidari

@ammarheidari ammarheidari commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Authority

W64 #213 remains ACTIVE. PR #245 established the protected-main backend truth model for consumer live/history/SLO observations.

UI parity slice

  • expose bounded consumer live operational evidence in the existing consumer detail surface;
  • show explicit evidence truth using existing status presentation;
  • render at most 100 lag-trend rows with provider/truncation/limit evidence;
  • keep unavailable provider evidence unavailable rather than coercing it to zero;
  • make SLO evaluation operator-triggered and read-only;
  • surface compliance/burn only when backend evidence is numeric;
  • preserve core consumer detail even if analytics endpoints fail.

Safety

  • no polling loop, websocket, chart dependency or unbounded history retrieval;
  • no new metrics provider;
  • no fabricated throughput/latency;
  • no mutation path or Kafka/provider bypass;
  • SLO evaluation does not create alerts or mutate Kafka.

Exact head: 970183cce92c1d53db5fc17694c65d4ceb339a2d.

Refs #213.

Corrective exact-head closeout

  • consumer analytics/detail/SLO responses are selection-generation fenced;
  • SLO results are cleared on input change and render their immutable evaluated definition/window;
  • frontend regression tests cover both review findings;
  • source is frozen pending fresh exact-head CI, CODEOWNER approval and Codex review.

Final corrective exact-head

  • client no longer overrides server-configured historical point ceilings;
  • rendering remains bounded to 100 trend rows independently of query ceiling;
  • SLO input changes invalidate in-flight evaluations with a dedicated generation fence;
  • all prior review threads are resolved;
  • source is frozen pending fresh exact-head CI, CODEOWNER and Codex review.

Final UI error-isolation corrective

  • SLO failures use dedicated sloError state;
  • SLO input edits invalidate only SLO request/result/error state;
  • live/trend operationalError remains visible and cannot be hidden by SLO edits;
  • regression tests cover error-state isolation;
  • source is frozen pending fresh exact-head CI, CODEOWNER approval and Codex review.

Busy-state isolation corrective

  • live/trend loading and SLO evaluation use independent busy states;
  • SLO input edits cannot clear analytics loading;
  • SLO evaluation is disabled while analytics loading or another SLO evaluation is active;
  • consumer switches reset both busy domains;
  • all prior review threads are resolved;
  • source is frozen pending fresh exact-head CI, CODEOWNER approval and Codex review.

Active-request corrective

  • SLO activity is tracked by active request count, not stale result generation;
  • invalidated requests remain counted until their own completion;
  • SLO action stays disabled while any evaluation is physically in flight;
  • all prior review threads are resolved;
  • source is frozen pending fresh exact-head CI, CODEOWNER approval and Codex review.

Context-switch request-count corrective

  • consumer/cluster switches invalidate SLO result generation without resetting physical active-request counts;
  • every SLO request decrements the active count only in its own completion path;
  • older requests cannot erase newer request busy state;
  • all prior review threads are resolved;
  • source is frozen pending fresh exact-head CI, CODEOWNER approval and Codex review.

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 8606b5440b6c418b2564268ed0e91bde542fe1b0 only. Focus on W64 UI truth preservation, bounded trend rendering, operator-triggered SLO behavior, API contract parity and ensuring analytics failures cannot break core consumer read detail.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T14:06:40.139132Z 970183c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8606b5440b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx
Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
@ammarheidari
ammarheidari force-pushed the w64-operator-ui-parity branch from 4ea3506 to 9cc6159 Compare October 4, 2026 13:07

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 9cc6159d5093c8a0846494ec15ca09ba9c002e1d only. The prior P1/P2 findings are addressed with per-consumer generation fencing across detail/live/trend/SLO commits, stale success/failure/finally suppression, SLO-result clearing on input changes, and immutable returned definition/window rendering. Please focus on those corrections and regressions.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cc6159d50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
akhiabanchian
akhiabanchian previously approved these changes Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head c1db2fe81a6f71cc4b006b9fdb67018cb51751ae only. The prior P2 findings are addressed: frontend trend/SLO calls defer point ceilings to the server while rendering stays capped, and SLO input edits invalidate in-flight requests via a dedicated SLO generation fence across success/failure/finally. Please focus on these corrections and regressions.

akhiabanchian
akhiabanchian previously approved these changes Oct 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1db2fe81a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head d9885663147f6bc6013a5d80b65b2c9962dfc848 only. The prior P2 is addressed by separating SLO-specific errors from live/trend analytics errors; SLO input changes invalidate only SLO request/result/error state, while operational analytics failures remain visible. Please focus on this correction and regressions.

akhiabanchian
akhiabanchian previously approved these changes Oct 4, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d988566314

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head a5fd9bc41f2504460191d52fd297617a0aff42a8 only. The prior P2 is addressed with independent analytics/SLO busy states; SLO edits invalidate only SLO state, consumer switches reset both domains, and SLO evaluation is disabled while analytics loading or another SLO request is active. Please focus on this correction and regressions.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5fd9bc41f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
@ammarheidari
ammarheidari force-pushed the w64-operator-ui-parity branch from 0b99718 to 7f81d33 Compare October 4, 2026 13:59

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 7f81d3359cf22a23dff0be6d92886080cac310c6 only. The prior P2 is addressed with active SLO request counting: invalidated requests remain counted until their own finally path, so the SLO action cannot re-enable while any evaluation is still physically in flight. Please focus on this correction and regressions.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f81d3359c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/frontend/src/features/readviews/ReadViewsExplorer.tsx Outdated
Signed-off-by: Ammar Heidari <ammar@arad-itc.org>
@ammarheidari
ammarheidari force-pushed the w64-operator-ui-parity branch from 3bd5211 to 970183c Compare October 4, 2026 14:02

Copy link
Copy Markdown
Contributor Author

@codex review

Please review exact head 970183cce92c1d53db5fc17694c65d4ceb339a2d only. The prior P2 is addressed by preserving active SLO request counts across consumer/cluster switches: switches invalidate result generation but never zero physical in-flight counts, and each request decrements only in its own finally path. Please focus on this correction and regressions.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 970183cce9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants