Repository navigation
test(aks): run both AKS suites through the Helm chart - #780
Open
gaurang-delavadiya wants to merge 1 commit into
Open
gaurang-delavadiya wants to merge 1 commit into
gaurang-delavadiya wants to merge 1 commit into
Conversation
The Container Insights suite in terraform/azure/aks installs the amazon-cloudwatch-observability Helm chart, but the OTLP suite still deploys a hand-written default:otel DaemonSet, and the suite is chosen with test_mode. Install the chart for both suites and register them in the test case generator so CI runs them from the generated matrix, like EKS. - terraform/azure/aks: install the chart with helm_release for both suites (OTLP with agent.config=default:otel), patch the agent image under test in the AmazonCloudWatchAgent resources, and select the suite from test_dir (test_mode removed) - Rename helm_charts_branch to helm_chart_branch, matching the EKS stacks and the chart branch step in the agent workflow; add helm_set_values for extra chart values - generator: add the aks test type (OTLP and Container Insights) and aks_test_matrix.json - The AKS Go tests are unchanged
gaurang-delavadiya
marked this pull request as draft
October 9, 2026 09:43
This was referenced Oct 9, 2026
gaurang-delavadiya
marked this pull request as ready for review
October 16, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
#778 moved the AKS Container Insights suite onto the amazon-cloudwatch-observability Helm chart, but
terraform/azure/aksstill deploys a hand-writtendefault:otelDaemonSet for the OTLP suite, and the suite is chosen with atest_modevariable that has to be kept in step withtest_dir. AKS is also not in the test case generator, so the agent workflow carries one hand-written job per AKS suite, while EKS suites only need a generator entry.Description of changes
terraform/azure/aksinstalls the chart for both suites withhelm_release(k8sMode=AKS). Both use thescripts/azure/setup.shvalues from test(containerinsights): run OTel Container Insights suites through the Helm chart #778 (containerInsights.enabled=false,containerLogs.enabled=false). The Container Insights suite addsotelContainerInsights.enabledandotelContainerInsights.logs.enabled; the OTLP suite setsagent.config=default:otelwith OTel Container Insights off.AmazonCloudWatchAgentresources, as the EKS stacks do. The ECR pull secret is attached to thecloudwatch-agentServiceAccount and the agent workloads are restarted.test_dir(validated).test_modeand the hand-written agent DaemonSet are removed.helm_charts_branchis renamed tohelm_chart_branch, the name used by the EKS stacks and by the chart branch step in the agent workflow.helm_set_valuesallows extra chart values.terraform/otlp_load_generator.shwithprefix = "aks".akstest type with both suites, andgenerator/resources/aks_test_matrix.json(Standard_D4s_v7).License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
terraform applyagainst AKS (eastus,Standard_D4s_v7), chart branchrelease-6.7.0(the branch the workflow resolves today), agent image7b574ef5:./test/azure/aks/containerinsights:TestAKSContainerInsightsPASS (node, cluster, KEDA and Karpenter metrics; node logs)../test/azure/aks:TestAKSPASS (Metrics: OTLP, SpanMetrics, Names; Logs; Traces).GenerateTestMatrixandAKSIntegrationTestscripts from ci: run AKS integration tests from the generated test matrix amazon-cloudwatch-agent#2342 were run locally against this branch, withterraform planin place of apply/destroy:aks_matrixfor eachtest_dir_filtervalue, chart branch resolution, and plan / plan -destroy for both rows pass.go vet -tags integration ./test/azure/...,gofmt,terraform validateandterraform fmt -checkpass.Related pull requests
test_mode, which this PR removes.