Repository navigation
ci: run AKS integration tests from the generated test matrix - #2342
Open
gaurang-delavadiya wants to merge 1 commit into
Open
gaurang-delavadiya wants to merge 1 commit into
gaurang-delavadiya wants to merge 1 commit into
Conversation
This was referenced Oct 9, 2026
Replace the hand-written AKSIntegrationTest and AKSContainerInsightsIntegrationTest jobs with a single AKSIntegrationTest matrix job fed by aks_matrix from the test case generator, matching EKSIntegrationTest. New AKS tests now only need a generator entry in the test repo. - GenerateTestMatrix outputs aks_matrix - Resolve the Helm chart branch (input, latest release-*, or main) and pass it to terraform/azure/aks
gaurang-delavadiya
force-pushed
the
convert-aks-tests-to-helm
branch
from
October 16, 2026 11:40
0c73813 to
4001026
Compare
gaurang-delavadiya
marked this pull request as ready for review
October 16, 2026 11:42
Contributor
|
This PR was marked stale due to lack of activity. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
The AKS suites run from two hand-written jobs,
AKSIntegrationTestandAKSContainerInsightsIntegrationTest, each with its own filter and terraform variables, so every new AKS suite needs a new job. The EKS jobs are driven by matrices from the test repo's test case generator. aws/amazon-cloudwatch-agent-test#780 adds AKS to the generator and selects the suite fromtest_dir.Description of changes
GenerateTestMatrixoutputsaks_matrixfromaks_complete_test_matrix.json, using the same filters as the other matrices.AKSIntegrationTestmatrix job replaces the two AKS jobs. The job name and WIP handling come from the matrix row, and it passestest_dir,aks_node_vm_size(frominstanceType) and the terraform directory from the row.helm_chart_branchinput, else the newestrelease-*branch of aws-observability/helm-charts, elsemain, as the EKS job does, and passes it ashelm_chart_branch.test_dir_filternow selects AKS rows the same way as the other matrix jobs, so./test/azurealone no longer selects the AKS jobs.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
GenerateTestMatrixandAKSIntegrationTestscripts were run locally against test(aks): run both AKS suites through the Helm chart amazon-cloudwatch-agent-test#780, withterraform planin place of apply/destroy:aks_matrixfor'',./test/azure/aks,./test/azure/aks/containerinsights,./test/azureand an unrelated filter; chart branch resolution (release-6.7.0) and the input override; plan and plan -destroy for both rows. All pass.actionlint: no new findings compared withmain.Requirements
Workflow-only change;
make fmtandmake lintare not affected.Merge after aws/amazon-cloudwatch-agent-test#780, which removes the
test_modevariable the current jobs pass.Integration Tests
To run integration tests against this PR, add the
ready for testinglabel.